From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: swhiteho@redhat.com, chris.mason@oracle.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block: BARRIER request should imply SYNC
Date: Thu, 17 Jun 2010 09:34:29 +0200 [thread overview]
Message-ID: <4C19D005.8090703@kernel.dk> (raw)
In-Reply-To: <20100617065416.GA19903@lst.de>
On 2010-06-17 08:54, Christoph Hellwig wrote:
>
> A barrier request should by defintion have priority in get_request
> and let the queue be unplugged immediately as it's blocking all forward
> progress due to the queue draining.
>
> Most filesystems already get this implicitly by the way how submit_bh
> treats the buffer_ordered flag, and gfs2 sets it explicitly. But btrfs
> and XFS are still forgetting to set the flag, as is blkdev_issue_flush
> and some places in DM/MD.
>
> For XFS on metadata heavy workloads this gives a consistent speedup
> in the 2-3% range.
Thanks Christoph, applied.
--
Jens Axboe
prev parent reply other threads:[~2010-06-17 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 6:54 [PATCH] block: BARRIER request should imply SYNC Christoph Hellwig
2010-06-17 7:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C19D005.8090703@kernel.dk \
--to=axboe@kernel.dk \
--cc=chris.mason@oracle.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.