From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34370 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPHpt-0004C7-Tf for qemu-devel@nongnu.org; Thu, 17 Jun 2010 12:21:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPHps-0006Y1-Um for qemu-devel@nongnu.org; Thu, 17 Jun 2010 12:21:01 -0400 Received: from smtp.citrix.com ([66.165.176.89]:42431) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPHps-0006Xp-RE for qemu-devel@nongnu.org; Thu, 17 Jun 2010 12:21:00 -0400 Message-ID: <4C1A4C63.6040907@citrix.com> Date: Thu, 17 Jun 2010 17:25:07 +0100 From: Julian Pidancet MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 5/5] linux fbdev display driver. References: <1276596347-9410-1-git-send-email-kraxel@redhat.com> <1276596347-9410-6-git-send-email-kraxel@redhat.com> <4C18FA58.5080808@citrix.com> <4C19FC5D.9070003@redhat.com> <4C1A3139.5020905@citrix.com> In-Reply-To: <4C1A3139.5020905@citrix.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "qemu-devel@nongnu.org" , Stefano Stabellini On 06/17/2010 03:29 PM, Julian Pidancet wrote: > > Hi, > > Thanks for spotting these errors. Here is a respin of my patch to address you concerns. > (The munmap call is included). > > Cheers, > > Julian > Oh, I actually tested the last patch only with the -nographic switch. There's still a segfault when starting qemu with vnc. You can fix it by adding a call to dpy_resize(ds) after the dcl = NULL; line in fbdev_display_uninit(). For some reason, the display is extremely slow when using vnc and fbdev at the same time. Julian