[Ocfs2-devel] [PATCH 1/2] ocfs2 fix o2dlm dlm run purgelist

[Srinivas Eeda <srinivas.eeda@oracle.com>]

On 6/17/2010 7:48 AM, Sunil Mushran wrote:
> On 06/17/2010 01:35 AM, Srinivas Eeda wrote:
>> On 6/17/2010 1:32 AM, Joel Becker wrote:
>>> On Wed, Jun 16, 2010 at 06:44:43PM -0700, Sunil Mushran wrote:
>>>   
>>>> One way to skip a lockres in the purgelist is to list_del_init() and
>>>> list_add_tail(). That simplifies the patch a lot.
>>>>
>>>> I have attached a quick & dirty patch. See if that satisfies all the
>>>> requirements.
>>>>     
>>>
>>> 	As far as I can tell from reading the code, the time_after()
>>> check is because they are time ordered.  Wouldn't moving it to the end
>>> violate that?
>>>   
>> right. that's why I didn't want to move used lockres to tail :)
>
>
> No. There is no need for time ordering. Or, am I missing something?
>
> We delay the purge incase the file system changes its mind and wants
> to reuse it. By delaying, we hold onto the mastery information. That's it.
>
So, should we preserve this? or purge the lockres  when it's on purge 
list? OR we could just update the last_used and move it to end of the 
list if it can be purged.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20100617/7cbbb416/attachment.html