From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] block: unify flags for struct bio and struct request
Date: Fri, 18 Jun 2010 11:33:33 +0200 [thread overview]
Message-ID: <4C1B3D6D.4080400@kernel.dk> (raw)
In-Reply-To: <20100618074704.GB13358@lst.de>
On 2010-06-18 09:47, Christoph Hellwig wrote:
> Remove the current bio flags and reuse the request flags for the bio, too.
> This allows to more easily trace the type of I/O from the filesystem
> down to the block driver. There were two flags in the bio that were
> missing in the requests: BIO_RW_UNPLUG and BIO_RW_AHEAD. Also I've
> renamed two request flags that had a superflous RW in them.
>
> Note that the flags are in bio.h despite having the REQ_ name - as
> blkdev.h includes bio.h that is the only way to go for now.
Good stuff, thanks Christoph. We need to be really careful with
this of course, I'll toss it into the testing mix.
--
Jens Axboe
next prev parent reply other threads:[~2010-06-18 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 7:47 [PATCH 2/2] block: unify flags for struct bio and struct request Christoph Hellwig
2010-06-18 9:07 ` Nick Piggin
2010-06-18 9:14 ` Christoph Hellwig
2010-06-18 9:33 ` Jens Axboe [this message]
2010-06-18 10:29 ` Jens Axboe
2010-06-18 16:57 ` Christoph Hellwig
2010-06-18 17:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1B3D6D.4080400@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.