From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 2/2] block: unify flags for struct bio and struct request Date: Fri, 18 Jun 2010 11:33:33 +0200 Message-ID: <4C1B3D6D.4080400@kernel.dk> References: <20100618074704.GB13358@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:36145 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759302Ab0FRJdr (ORCPT ); Fri, 18 Jun 2010 05:33:47 -0400 In-Reply-To: <20100618074704.GB13358@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2010-06-18 09:47, Christoph Hellwig wrote: > Remove the current bio flags and reuse the request flags for the bio, too. > This allows to more easily trace the type of I/O from the filesystem > down to the block driver. There were two flags in the bio that were > missing in the requests: BIO_RW_UNPLUG and BIO_RW_AHEAD. Also I've > renamed two request flags that had a superflous RW in them. > > Note that the flags are in bio.h despite having the REQ_ name - as > blkdev.h includes bio.h that is the only way to go for now. Good stuff, thanks Christoph. We need to be really careful with this of course, I'll toss it into the testing mix. -- Jens Axboe