From: Wolfgang Grandegger <wg@grandegger.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "Hans J. Koch" <hjk@linutronix.de>,
netdev@vger.kernel.org, socketcan-core@lists.berlios.de
Subject: Re: [PATCH] socketcan: add a driver for FlexCAN controllers.
Date: Fri, 18 Jun 2010 12:04:03 +0200 [thread overview]
Message-ID: <4C1B4493.70102@grandegger.com> (raw)
In-Reply-To: <4C1A2CDF.2040008@pengutronix.de>
On 06/17/2010 04:10 PM, Marc Kleine-Budde wrote:
> Hey Hans,
>
> Hans J. Koch wrote:
>> + priv->can.do_set_bittiming = flexcan_set_bittiming;
Yes, but we need to fix it globally anyway.
> using this callback is error prone, with respect to 3-sample and
> friends, see discussion on socketcan-core.
>
>> + priv->can.bittiming_const = &flexcan_bittiming_const;
>> + priv->can.do_set_mode = flexcan_set_mode;
>> + priv->can.restart_ms = 500;
>
> should this be set in the driver?
No, the default is manual restart for all drivers.
Wolfgang.
next prev parent reply other threads:[~2010-06-18 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 10:52 [PATCH] socketcan: add a driver for FlexCAN controllers Hans J. Koch
[not found] ` <20100617105201.GA2015-hikPBsva6T+Nj9Bq2fkWzw@public.gmane.org>
2010-06-17 14:10 ` Marc Kleine-Budde
2010-06-18 10:04 ` Wolfgang Grandegger [this message]
2010-06-18 9:47 ` Wolfgang Grandegger
[not found] ` <4C1B4098.3090800-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-06-18 10:16 ` Marc Kleine-Budde
[not found] ` <4C1B4796.3060506-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-06-18 10:33 ` Wolfgang Grandegger
[not found] ` <4C1B4B85.3010905-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-06-18 10:44 ` Marc Kleine-Budde
[not found] ` <4C1B4DF0.2090103-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-06-18 11:04 ` Wolfgang Grandegger
[not found] ` <4C1B52A7.3060607-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-06-18 11:21 ` Marc Kleine-Budde
[not found] ` <4C1B56BC.1050303-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-06-18 11:53 ` Wolfgang Grandegger
[not found] ` <4C1B5E1F.5080702-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-06-18 12:30 ` Wolfgang Grandegger
2010-06-18 12:00 ` Hans J. Koch
[not found] ` <20100618120044.GB2007-hikPBsva6T+Nj9Bq2fkWzw@public.gmane.org>
2010-06-18 12:19 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1B4493.70102@grandegger.com \
--to=wg@grandegger.com \
--cc=hjk@linutronix.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.