From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 2/2] block: unify flags for struct bio and struct request
Date: Fri, 18 Jun 2010 12:29:11 +0200
Message-ID: <4C1B4A77.3060100@kernel.dk>
References: <20100618074704.GB13358@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:60240 "EHLO kernel.dk"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759218Ab0FRK3Z (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 18 Jun 2010 06:29:25 -0400
In-Reply-To: <20100618074704.GB13358@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 2010-06-18 09:47, Christoph Hellwig wrote:
> Index: linux-2.6/drivers/md/dm.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/dm.c	2010-06-17 13:21:19.000000000 +0200
> +++ linux-2.6/drivers/md/dm.c	2010-06-17 13:22:15.631255880 +0200
> @@ -1301,7 +1301,7 @@ static void __split_and_process_bio(stru
>  
>  	ci.map = dm_get_live_table(md);
>  	if (unlikely(!ci.map)) {
> -		if (!bio_rw_flagged(bio, BIO_RW_BARRIER))
> +		if (!bio->bi_rw & REQ_HARDBARRIER)
>  			bio_io_error(bio);
>  		else
>  			if (!md->barrier_error)

That's not good either.

-- 
Jens Axboe