From: Jiri Slaby <jirislaby@gmail.com>
To: Suresh Rajashekara <suresh.raj+linuxomap@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-pm@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: wait_for_completion_interruptible does not wait !! [During PM suspend]
Date: Sun, 20 Jun 2010 09:51:31 +0200 [thread overview]
Message-ID: <4C1DC883.7090009@gmail.com> (raw)
In-Reply-To: <AANLkTik5x38mWno0EUGhaHDD_INLlpeaGSExGxjIC4as@mail.gmail.com>
On 06/20/2010 09:42 AM, Suresh Rajashekara wrote:
> On Sun, Jun 20, 2010 at 12:23 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
>> On 06/20/2010 08:52 AM, Suresh Rajashekara wrote:
>>> The ioctl waits on a completion variable (using
>>> wait_for_completion_interruptible).
>> ...
>>> I tried wait_for_completion instead, but now the kernel refuses to suspend.
>>
>> Do you check return value of wait_for_completion_interruptible and
>> return its value if nonzero?
>>
>> We need the code to comment, otherwise it's hard to say.
>
> No. I am not checking the return value of the
> wait_for_completion_interruptible. I can do it
I thought so. Generally, all *_interruptible functions return a value
which should be checked and propagated to upper layers.
--
js
next prev parent reply other threads:[~2010-06-20 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 7:42 wait_for_completion_interruptible does not wait !! [During PM suspend] Suresh Rajashekara
2010-06-20 7:42 ` Suresh Rajashekara
2010-06-20 7:51 ` Jiri Slaby [this message]
2010-06-20 7:51 ` Jiri Slaby
-- strict thread matches above, loose matches on Subject: below --
2010-06-20 7:42 Suresh Rajashekara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1DC883.7090009@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=suresh.raj+linuxomap@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.