From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCH 3/6]cifs Fix variable not set warnings
Date: Sun, 20 Jun 2010 06:29:04 -0700
Message-ID: <4C1E17A0.8010202@gmail.com>
References: <1276288869-16815-1-git-send-email-justinmattock@gmail.com> <1276288869-16815-4-git-send-email-justinmattock@gmail.com> <4C1E1602.7080700@alessandroguido.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-fsdevel-owner@vger.kernel.org>
In-Reply-To: <4C1E1602.7080700@alessandroguido.name>
Sender: linux-fsdevel-owner@vger.kernel.org
To: Alessandro Guido <ag@alessandroguido.name>
Cc: linux-kernel@vger.kernel.org, zippel@linux-m68k.org, linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au, linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On 06/20/2010 06:22 AM, Alessandro Guido wrote:
>> ...
>> @@ -734,7 +733,6 @@ cifs_lookup(struct inode *parent_dir_inode, struct
>> dentry *direntry,
>> direntry->d_op =&cifs_dentry_ops;
>> d_add(direntry, newInode);
>> if (posix_open)
>> - filp = lookup_instantiate_filp(nd, direntry, NULL);
>> /* since paths are not looked up by component - the parent
>> directories are presumed to be good here */
>> renew_parental_timestamps(direntry);
>> ...
>
> This is wrong, now "renew_parental_timestamps(direntry)" is in the if body.
>
>
>

have you had a chance to look at the later one I had sent in yesterday?
if so out of the two, which might be a better bet(keep in mind the first 
set has whitespace issues).

Justin P. Mattock