From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Add option to disable fibre on M88E1111 PHY for PPC4xx
Date: Sun, 20 Jun 2010 22:56:17 -0700 [thread overview]
Message-ID: <4C1EFF01.6060309@gmail.com> (raw)
In-Reply-To: <1276162095-14035-1-git-send-email-sr@denx.de>
Hi Stefan,
On 6/10/2010 2:28 AM, Stefan Roese wrote:
> By defining CONFIG_M88E1111_DISABLE_FIBRE boards can configure the
> M88E1111 PYH to disable fibre. This is needed for an upcoming PPC460GT
> based board, which has fibre/copper auto-selection enabled by default.
> This doesn't seem to work. So we disable fibre in the PHY register.
>
>
I don't mean to be pedantic, but unless this is a Fibre Channel link
(and it isn't), the appropriate spelling is 'FIBER'. I say this
reluctantly, having been raised using British/European spelling...
> Signed-off-by: Stefan Roese<sr@denx.de>
> Cc: Ben Warren<biggerbadderben@gmail.com>
> ---
> drivers/net/4xx_enet.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/4xx_enet.c b/drivers/net/4xx_enet.c
> index 2fac641..2958903 100644
> --- a/drivers/net/4xx_enet.c
> +++ b/drivers/net/4xx_enet.c
> @@ -1095,6 +1095,11 @@ static int ppc_4xx_eth_init (struct eth_device *dev, bd_t * bis)
> miiphy_write (dev->name, reg, 0x18, 0x4101);
> miiphy_write (dev->name, reg, 0x09, 0x0e00);
> miiphy_write (dev->name, reg, 0x04, 0x01e1);
> +#if defined(CONFIG_M88E1111_DISABLE_FIBRE)
> + miiphy_read(dev->name, reg, 0x1b,®_short);
> + reg_short |= 0x8000;
> + miiphy_write(dev->name, reg, 0x1b, reg_short);
> +#endif
> #endif
> #if defined(CONFIG_M88E1112_PHY)
> if (bis->bi_phymode[devnum] == BI_PHYMODE_SGMII) {
>
regards,
Ben
next prev parent reply other threads:[~2010-06-21 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 9:28 [U-Boot] [PATCH] net: Add option to disable fibre on M88E1111 PHY for PPC4xx Stefan Roese
2010-06-21 5:56 ` Ben Warren [this message]
2010-06-28 13:40 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1EFF01.6060309@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.