Re: [PATCH 1/3] writeback: simplify the write back thread queue

[Jens Axboe <axboe@kernel.dk>]

On 2010-06-19 23:07, Christoph Hellwig wrote:
> First remove items from work_list as soon as we start working on them.  This
> means we don't have to track any pending or visited state and can get
> rid of all the RCU magic freeing the work items - we can simply free
> them once the operation has finished.  Second use a real completion for
> tracking synchronous requests - if the caller sets the completion pointer
> we complete it, otherwise use it as a boolean indicator that we can free
> the work item directly.  Third unify struct wb_writeback_args and struct
> bdi_work into a single data structure, wb_writeback_work.  Previous we
> set all parameters into a struct wb_writeback_args, copied it into
> struct bdi_work, copied it again on the stack to use it there.  Instead
> of just allocate one structure dynamically or on the stack and use it
> all the way through the stack.

I'm fine with this, we can always bring back support for > 1 writeback
thread per bdi when the need arises.

-- 
Jens Axboe