Re: XCP: pygrub missing ext4 support.

[Michal Novotny <minovotn@redhat.com>]

On 06/21/2010 01:38 PM, David Markey wrote:
> The *non-e2fsprogs* implementation, 
> i.e. tools/libfsimage/ext2fs/fsys_ext2fs.c has ext4 support already.

Oh, ok, provided the fact that e2fsprogs implementation is being just 
simply linked to the e2fsprogs library upgrading the package to the 
newest/upstream package is the simplest thing you could do.

Michal

>
>
> On 21 June 2010 12:29, Michal Novotny <minovotn@redhat.com 
> <mailto:minovotn@redhat.com>> wrote:
>
>     On 06/21/2010 01:26 PM, David Markey wrote:
>
>         Well, which ever way we do it, either using the built in
>         libfsimage ext4 support, or upgrading e2fsprogs, we should
>         choose one?
>
>
>
>     Well, when using libfsimage *non-e2fsprogs* implementation the
>     ext4 support have to be added manually but when using e2fsprogs
>     implementation (i.e. the version linked with e2fsprogs) I
>     recommend upgrading your version of e2fsprogs to the
>     newest/upstream version.
>
>     Michal
>
>         On 21 June 2010 10:59, Michal Novotny <minovotn@redhat.com
>         <mailto:minovotn@redhat.com> <mailto:minovotn@redhat.com
>         <mailto:minovotn@redhat.com>>> wrote:
>
>            On 06/19/2010 06:07 PM, Pasi Kärkkäinen wrote:
>
>                On Sat, Jun 19, 2010 at 05:00:57PM +0100, David Markey
>         wrote:
>
>                       XCP pygrub should have ext4 support.
>                       It currently doesn't because the libfsimage
>         ext2fs-lib
>                    module is linked
>                       against libext2fs, which doesnt have ext4
>         support in XCP.
>                       Instead, XCP should use the ext2fs module that comes
>                    with libfsimage,
>                       which has ext4 support.
>                       Most new releases of distributions has it as their
>                    default filesystem.
>                       Most notably, Ubuntu 10.04
>
>
>                Also Fedora 12, Fedora 13, upcoming Debian 6.0
>         ("Squeeze") and
>                RHEL6.
>
>                -- Pasi
>
>
>            Well, this is not the Xen issue here. We're having this
>         fixed in
>            RHEL-5 by simply reinstalling the e2fsprogs package to the
>         latest
>            one, although in case of RHEL-5 it's been renamed to e4fsprogs.
>            The simplest thing you can do about this is to reinstall the
>            e2fsprogs package on the host machine and it will be
>         working fine
>            - at least it was when I did test it on RHEL-5 some time ago.
>
>            Simply put, reinstalling the e2fsprogs to the latest
>         version will
>            do the job and allow ext4 functionality to pygrub.
>
>            Michal
>
>
>
>                       An easy way for the build to use ext2fs instead of
>                    ext2fs-lib, is to not
>                       have ext2fs/ext2fs.h present.
>                       Alternatively this patch hard codes it.
>                       (From 4.0)
>                       --- a/tools/libfsimage/Makefile         2010-06-19
>                    16:52:04.231221516
>                       +0100
>                       +++ b/tools/libfsimage/Makefile         2010-06-19
>                    16:52:08.803250922
>                       +0100
>                       @@ -1,8 +1,7 @@
>                        XEN_ROOT = ../..
>                        include $(XEN_ROOT)/tools/Rules.mk
>
>                       -SUBDIRS-y = common ufs reiserfs iso9660 fat zfs
>                       -SUBDIRS-y += $(shell env CC="$(CC)"
>         ./check-libext2fs)
>                       +SUBDIRS-y = common ufs reiserfs iso9660 fat zfs
>         ext2fs
>
>                        .PHONY: all clean install
>                        all clean install: %: subdirs-%
>
>
>                    _______________________________________________
>                    Xen-devel mailing list
>         Xen-devel@lists.xensource.com
>         <mailto:Xen-devel@lists.xensource.com>
>         <mailto:Xen-devel@lists.xensource.com
>         <mailto:Xen-devel@lists.xensource.com>>
>
>         http://lists.xensource.com/xen-devel
>
>
>                _______________________________________________
>                Xen-devel mailing list
>         Xen-devel@lists.xensource.com
>         <mailto:Xen-devel@lists.xensource.com>
>         <mailto:Xen-devel@lists.xensource.com
>         <mailto:Xen-devel@lists.xensource.com>>
>
>         http://lists.xensource.com/xen-devel
>
>
>
>            --     Michal Novotny<minovotn@redhat.com
>         <mailto:minovotn@redhat.com> <mailto:minovotn@redhat.com
>         <mailto:minovotn@redhat.com>>>, RHCE
>
>            Virtualization Team (xen userspace), Red Hat
>
>
>
>            _______________________________________________
>            Xen-devel mailing list
>         Xen-devel@lists.xensource.com
>         <mailto:Xen-devel@lists.xensource.com>
>         <mailto:Xen-devel@lists.xensource.com
>         <mailto:Xen-devel@lists.xensource.com>>
>
>         http://lists.xensource.com/xen-devel
>
>
>
>         _______________________________________________
>         Xen-devel mailing list
>         Xen-devel@lists.xensource.com
>         <mailto:Xen-devel@lists.xensource.com>
>         http://lists.xensource.com/xen-devel
>
>
>
>     -- 
>     Michal Novotny<minovotn@redhat.com <mailto:minovotn@redhat.com>>, RHCE
>     Virtualization Team (xen userspace), Red Hat
>
>


-- 
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat