From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used
Date: Mon, 21 Jun 2010 09:14:10 -0700 [thread overview]
Message-ID: <4C1F8FD2.6090809@gmail.com> (raw)
In-Reply-To: <20100621093436.376b819a@pedra>
On 06/21/2010 05:34 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 14 Jun 2010 22:48:34 -0700
> "Justin P. Mattock"<justinmattock@gmail.com> escreveu:
>
>> Resend due to a whitespace issue I created by mistake.
>> The below patch fixes a warning message create by gcc 4.6.0
>
> It seems OK for me, but you shouldn't be sending it to be applied at reiserfs-devel ML.
> Instead, it should be sent to linux-media ML, and applied via my tree.
>
I should of used get_maintainer.pl to find the correct list to send this
too(instead I just looked into the MAINTAINERS file).
I'll resend.
>>
>> CC [M] drivers/media/common/tuners/tuner-simple.o
>> drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
>> drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>> Reviewed-By: Mauro Carvalho Chehab<mchehab@redhat.com>
>>
>> ---
>> drivers/media/common/tuners/tuner-simple.c | 3 ---
>> 1 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
>> index 8abbcc5..84900fa 100644
>> --- a/drivers/media/common/tuners/tuner-simple.c
>> +++ b/drivers/media/common/tuners/tuner-simple.c
>> @@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
>> struct tuner_simple_priv *priv = fe->tuner_priv;
>> u8 config, cb;
>> u16 div;
>> - struct tunertype *tun;
>> u8 buffer[4];
>> int rc, IFPCoff, i;
>> enum param_type desired_type;
>> struct tuner_params *t_params;
>>
>> - tun = priv->tun;
>> -
>> /* IFPCoff = Video Intermediate Frequency - Vif:
>> 940 =16*58.75 NTSC/J (Japan)
>> 732 =16*45.75 M/N STD
>
>
Justin P. Mattock
next prev parent reply other threads:[~2010-06-21 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 5:48 [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used Justin P. Mattock
2010-06-21 12:34 ` Mauro Carvalho Chehab
2010-06-21 16:14 ` Justin P. Mattock [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-21 16:15 Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1F8FD2.6090809@gmail.com \
--to=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.