From: Sachin Sant <sachinp@in.ibm.com>
To: linux-next@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
arnd@arndb.de, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: -next June 21: WARNING: at include/linux/tty.h
Date: Tue, 22 Jun 2010 10:55:54 +0530 [thread overview]
Message-ID: <4C204962.70208@in.ibm.com> (raw)
In-Reply-To: <20100621170056.2fcf10ad.sfr@canb.auug.org.au>
With next-20100621 on a x86_64 box came across this warning :
TCP cubic registered
registered taskstats version 1
------------[ cut here ]------------
WARNING: at include/linux/tty.h:589 tty_open+0x76/0x57a()
Hardware name: BladeCenter LS21 -[79716AA]-
Modules linked in:
Pid: 1, comm: swapper Not tainted 2.6.35-rc3-autotest-next-20100621 #1
Call Trace:
[<ffffffff812428d8>] ? tty_open+0x76/0x57a
[<ffffffff8103cf39>] warn_slowpath_common+0x80/0xae
[<ffffffff8103cf7c>] warn_slowpath_null+0x15/0x17
[<ffffffff812428d8>] tty_open+0x76/0x57a
[<ffffffff810d4544>] ? exact_match+0x0/0x9
[<ffffffff810d491f>] chrdev_open+0x133/0x152
[<ffffffff810d47ec>] ? chrdev_open+0x0/0x152
[<ffffffff810d07b4>] __dentry_open+0x140/0x252
[<ffffffff810d0990>] nameidata_to_filp+0x3e/0x4f
[<ffffffff810db588>] do_last+0x51a/0x643
[<ffffffff810dd621>] do_filp_open+0x23d/0x5f8
[<ffffffff810c1ba8>] ? slab_node+0x3c/0x78
[<ffffffff810d05a1>] do_sys_open+0x5a/0xf0
[<ffffffff810d0660>] sys_open+0x1b/0x1d
[<ffffffff818e66fc>] kernel_init+0x1b3/0x220
[<ffffffff810036d4>] kernel_thread_helper+0x4/0x10
[<ffffffff818e6549>] ? kernel_init+0x0/0x220
[<ffffffff810036d0>] ? kernel_thread_helper+0x0/0x10
---[ end trace 108cb769a1c0e534 ]---
This warning seem to have been introduced with next-20100617.
The corresponding code is :
585 static inline void tty_lock(void) __acquires(kernel_lock)
586 {
587 #ifdef CONFIG_LOCK_KERNEL
588 /* kernel_locked is 1 for !CONFIG_LOCK_KERNEL */
589 WARN_ON(kernel_locked());
590 #endif
591 lock_kernel();
592 }
which was added by commit 01510c869f9..
tty: replace BKL with a new tty_lock
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
next prev parent reply other threads:[~2010-06-22 5:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 7:00 linux-next: Tree for June 21 Stephen Rothwell
2010-06-21 16:00 ` linux-next: Tree for June 21 (staging/easycap) Randy Dunlap
2010-06-22 22:36 ` Greg KH
2010-06-23 18:06 ` Randy Dunlap
2010-06-23 22:09 ` Greg KH
2010-06-22 5:25 ` Sachin Sant [this message]
2010-06-23 6:55 ` -next June 21: WARNING: at include/linux/tty.h Stephen Rothwell
2010-06-23 7:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C204962.70208@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.