From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35093 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQzQC-0007gl-UG for qemu-devel@nongnu.org; Tue, 22 Jun 2010 05:05:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OQzBu-0001Tm-DW for qemu-devel@nongnu.org; Tue, 22 Jun 2010 04:50:47 -0400 Received: from david.siemens.de ([192.35.17.14]:18344) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQzBu-0001TW-1c for qemu-devel@nongnu.org; Tue, 22 Jun 2010 04:50:46 -0400 Message-ID: <4C207962.2040000@siemens.com> Date: Tue, 22 Jun 2010 10:50:42 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev References: <1276878387-9489-1-git-send-email-miguel.filho@gmail.com> <20100621114259.13e615ee@redhat.com> <4C1F7B64.1040202@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: "avi@redhat.com" , Miguel Di Ciurcio Filho , "qemu-devel@nongnu.org" , Luiz Capitulino Markus Armbruster wrote: > Jan Kiszka writes: > >> Luiz Capitulino wrote: >>> On Fri, 18 Jun 2010 13:26:27 -0300 >>> Miguel Di Ciurcio Filho wrote: >>> >>>> These commands show the information about active backend network devices. >>>> >>>> Signed-off-by: Miguel Di Ciurcio Filho >>>> --- >>>> qemu-monitor.hx | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> 1 files changed, 105 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/qemu-monitor.hx b/qemu-monitor.hx >>>> index 9f62b94..8fc5ed6 100644 >>>> --- a/qemu-monitor.hx >>>> +++ b/qemu-monitor.hx >>>> @@ -1674,6 +1674,111 @@ show the various VLANs and the associated devices >>>> ETEXI >>>> >>>> STEXI >>>> +@item info netdev >>>> +show information about the current backend network devices >>>> +ETEXI >>>> +SQMP >>>> +query-netdev >>>> +------------ >>>> + >>>> +Each device is represented by a json-object. The returned value is a json-array >>>> +of all devices. >>>> + >>>> +Each json-object contains the following: >>>> + >>>> +- "id": the device's ID, must be unique (json-string) >>> There were some talking about changing this to 'device. Jan, Markus? >> Only for qdev. Should be a different namespace here. > > Huh? > > We need to point to the NIC here, i.e. we need a unambigous name. > Device ID is fine, but it's optional. Canonical qdev path? Unless I'm still on the wrong track: 'peer' should point to the front-end, this ID describes the back-end, and that's not a qdev thing. Still, dumping the peer's qdev path along its (optional) ID might be worth a thought. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux