From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55417 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQzr9-0003uq-AU for qemu-devel@nongnu.org; Tue, 22 Jun 2010 05:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OQzr8-0007Ih-4w for qemu-devel@nongnu.org; Tue, 22 Jun 2010 05:33:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43593) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQzr7-0007IP-Ug for qemu-devel@nongnu.org; Tue, 22 Jun 2010 05:33:22 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5M9XJGn025523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Jun 2010 05:33:20 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5M9XIrs019789 for ; Tue, 22 Jun 2010 05:33:19 -0400 Message-ID: <4C20835D.4070200@redhat.com> Date: Tue, 22 Jun 2010 12:33:17 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu-option: Reject anti-social IDs References: <1275998066-2796-1-git-send-email-armbru@redhat.com> In-Reply-To: <1275998066-2796-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, kraxel@redhat.com On 06/08/2010 02:54 PM, Markus Armbruster wrote: > Restrict IDs to letters, digits, '-', '.', '_', starting with a > letter. > > This takes care of '/' in qdev IDs breaking qbus_find(). > > Broke autotest (used leading numeric char). Patch posted. -- error compiling committee.c: too many arguments to function