From: Tim Gardner <timg@tpi.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, ole@ans.pl
Subject: Re: [PATCH] net-next-2.6, Complete deprecation of CONFIG_NF_CT_ACCT
Date: Tue, 22 Jun 2010 06:40:56 -0600 [thread overview]
Message-ID: <4C20AF58.1070900@tpi.com> (raw)
In-Reply-To: <4C20545A.90405@trash.net>
On 06/22/2010 12:12 AM, Patrick McHardy wrote:
> Tim Gardner wrote:
>> Hi,
>>
>> I noticed some noise in my server log, so I thought it might be time to
>> finish this deprecation. One concern I have is about xt_connbytes. The
>> Kconfig for NETFILTER_XT_MATCH_CONNBYTES used to 'SELECT NF_CT_ACCT'
>> which forced nf_conntrack.acct=1. As long as the value of
>> NF_CT_ACCT_DEFAULT
>> remains 1, then xt_connbytes should be OK.
>
> Yeah, but we need to take care of the other case anyways. As I've
> repeatedly stated, connbytes needs to enable accounting when the
> first rule using it is added.
>
I thought you might say that. Lemme see what I can come up with.
> You also don't need to update the defconfigs, architecture maintainers
> can take care of that.
ack
rtg
--
Tim Gardner timg@tpi.com www.tpi.com
OR 503-601-0234 x102 MT 406-443-5357
next prev parent reply other threads:[~2010-06-22 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 17:52 [PATCH] net-next-2.6, Complete deprecation of CONFIG_NF_CT_ACCT Tim Gardner
2010-06-22 6:12 ` Patrick McHardy
2010-06-22 12:40 ` Tim Gardner [this message]
2010-06-22 12:43 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C20AF58.1070900@tpi.com \
--to=timg@tpi.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.