[Qemu-devel] Re: [PATCH 1/2] rtc: Parse the 'driftfix' option only for TARGET_I386

[Paolo Bonzini <pbonzini@redhat.com>]

On 06/23/2010 04:29 PM, Amit Shah wrote:
> The driftfix option is only useful for Windows guests, and for the x86
> architecture, so limit the option parsing to TARGET_I386. This ifdef
> conditional is moved from qemu-config.c to vl.c. The next patch will fix
> a bug where the driftfix option wasn't exposed at all even to the x86
> architecture.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
> ---
>   vl.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 920717a..f9c8086 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -418,6 +418,7 @@ static void configure_rtc(QemuOpts *opts)
>               exit(1);
>           }
>       }
> +#ifdef TARGET_I386
>       value = qemu_opt_get(opts, "driftfix");
>       if (value) {
>           if (!strcmp(value, "slew")) {
> @@ -429,6 +430,7 @@ static void configure_rtc(QemuOpts *opts)
>               exit(1);
>           }
>       }
> +#endif
>   }
>
>   /***********************************************************/

This file is compiled only once for upstream qemu, so it will never see 
TARGET_I386.  Any reason to have the #ifdef at all?

Paolo