Re: [PATCH] select NOP_USB_XCEIV for OMAP4

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

Koen Kooi wrote:

>>> Add select statement to force selection of NOP_USB_XCEIV for OMAP4.

>>> Signed-off-by: David Anders <x0132446@ti.com>
>>> ---
>>> drivers/usb/musb/Kconfig |    1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)

>>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>>> index cfd38ed..e4624bc 100644
>>> --- a/drivers/usb/musb/Kconfig
>>> +++ b/drivers/usb/musb/Kconfig
>>> @@ -11,6 +11,7 @@ config USB_MUSB_HDRC
>>> 	depends on (USB || USB_GADGET)
>>> 	depends on (ARM || (BF54x && !BF544) || (BF52x && !BF522 && !BF523))
>>> 	select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN)
>>> +	select NOP_USB_XCEIV if ARCH_OMAP4
>>> 	select TWL4030_USB if MACH_OMAP_3430SDP
>>> 	select USB_OTG_UTILS
>>> 	tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'

>> Shouldn't this be a board-specific option, and not set for every
>> OMAP4-based config?

> If that's true, why do the  davinci and blackfin archs force it?

    DaVincis have an integrated transceiver.

WBR, Sergei