From: Jens Axboe <axboe@kernel.dk>
To: Tao Ma <tao.ma@oracle.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
stable@kernel.org, hch@lst.de, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] block: Don't count_vm_events for discard bio in submit_bio.
Date: Thu, 24 Jun 2010 08:14:40 +0200 [thread overview]
Message-ID: <4C22F7D0.6070105@kernel.dk> (raw)
In-Reply-To: <1277339295-6524-1-git-send-email-tao.ma@oracle.com>
On 2010-06-24 02:28, Tao Ma wrote:
> Hi Andrew,
>> Yes, that's a buglet.
>>
>> Note that Christoph's "[PATCH, RFC] block: don't allocate a payload for
>> discard request" will fix it in a better way. That patch is in
>> linux-next now, but I expect it will be taken out again (quickly,
>> please) because Mike has found a number of problems with it.
> ok, I haven't noticed that. thanks for the info.
>>
>> Your patch looks like a decent temporary fix for mainline, and a
>> permanent one for -stable.
> I am sorry, but I made a mistake. BIO_RW_DISCARD is a enum for bit offset.
> So the right check should be rw & (1 << BIO_RW_DISCARD).
> I have regenerated the patch. Sorry for the inconvenience.
Thanks, this one looks good. Applied.
--
Jens Axboe
prev parent reply other threads:[~2010-06-24 6:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 3:24 [PATCH] block: Don't count_vm_events for discard bio in submit_bio Tao Ma
2010-06-23 19:40 ` Andrew Morton
2010-06-23 20:41 ` Mike Snitzer
2010-06-24 0:28 ` [PATCH v2] " Tao Ma
2010-06-24 6:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C22F7D0.6070105@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tao.ma@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.