From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>, qemu list <qemu-devel@nongnu.org>,
Gleb Natapov <gleb@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix
Date: Thu, 24 Jun 2010 12:02:35 +0200 [thread overview]
Message-ID: <4C232D3B.8050307@redhat.com> (raw)
In-Reply-To: <a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com>
On 06/23/10 16:44, Amit Shah wrote:
> qemu-config.c doesn't contain any target-specific code, and the
> TARGET_I386 conditional code didn't get compiled as a result. Removing
> this enables the driftfix parameter for rtc.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
> qemu-config.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
I really don't like exposing all these options in targets where they are
not functional. It would be really nice if we could come up with a
better way to handle this without just exposing them globally.
Cheers,
Jes
next prev parent reply other threads:[~2010-06-24 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 14:44 [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix Amit Shah
2010-06-23 14:50 ` [Qemu-devel] " Juan Quintela
2010-06-23 14:50 ` Paolo Bonzini
2010-06-24 10:02 ` Jes Sorensen [this message]
2010-07-14 13:32 ` [Qemu-devel] " Amit Shah
2010-07-27 9:48 ` [Qemu-devel] [PING^2] " Paolo Bonzini
2010-08-06 11:12 ` [Qemu-devel] " Daniel P. Berrange
2010-08-06 20:40 ` Amit Shah
2010-08-09 13:29 ` Anthony Liguori
2010-08-19 15:19 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C232D3B.8050307@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=amit.shah@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.