From: Wayne Boyer <wayneb@linux.vnet.ibm.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] ipr: change endian swap key to match hardware spec change
Date: Thu, 24 Jun 2010 17:00:59 -0700 [thread overview]
Message-ID: <4C23F1BB.1010600@linux.vnet.ibm.com> (raw)
In-Reply-To: <4C23C15F.3090000@linux.vnet.ibm.com>
On 06/24/2010 01:34 PM, Wayne Boyer wrote:
> The value used to change the endian representation on the new adapters has
> changed. This patch updates that value.
>
> Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
> ---
>
> drivers/scsi/ipr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/scsi/ipr.h
> ===================================================================
> --- a/drivers/scsi/ipr.h 2010-06-23 11:21:57.000000000 -0700
> +++ b/drivers/scsi/ipr.h 2010-06-23 11:22:08.000000000 -0700
> @@ -1257,7 +1257,7 @@ struct ipr_interrupt_offsets {
> unsigned long dump_addr_reg;
> unsigned long dump_data_reg;
>
> -#define IPR_ENDIAN_SWAP_KEY 0x000C0C00
> +#define IPR_ENDIAN_SWAP_KEY 0x000B0B00
The original patch has the wrong value. I mistook "8" for "B" in the
spec. The corrected patch is below.
---
The value used to change the endian representation on the new adapters has
changed. This patch updates that value.
Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
---
drivers/scsi/ipr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/scsi/ipr.h
===================================================================
--- a/drivers/scsi/ipr.h 2010-06-23 11:21:57.000000000 -0700
+++ b/drivers/scsi/ipr.h 2010-06-24 16:45:34.000000000 -0700
@@ -1257,7 +1257,7 @@ struct ipr_interrupt_offsets {
unsigned long dump_addr_reg;
unsigned long dump_data_reg;
-#define IPR_ENDIAN_SWAP_KEY 0x000C0C00
+#define IPR_ENDIAN_SWAP_KEY 0x00080800
unsigned long endian_swap_reg;
};
prev parent reply other threads:[~2010-06-25 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100624203107.468479055@linux.vnet.ibm.com>
2010-06-24 20:34 ` [PATCH 1/2] ipr: add support for new Obsidian-E embedded adapter Wayne Boyer
2010-06-24 20:34 ` [PATCH 2/2] ipr: change endian swap key to match hardware spec change Wayne Boyer
2010-06-25 0:00 ` Wayne Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C23F1BB.1010600@linux.vnet.ibm.com \
--to=wayneb@linux.vnet.ibm.com \
--cc=James.Bottomley@suse.de \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.