From: Jeff Garzik <jgarzik@pobox.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH ethtool 4/5] ethtool: Implement named message type flags
Date: Fri, 25 Jun 2010 13:11:21 -0400 [thread overview]
Message-ID: <4C24E339.6000606@pobox.com> (raw)
In-Reply-To: <1277477385.2094.9.camel@achroite.uk.solarflarecom.com>
On 06/25/2010 10:49 AM, Ben Hutchings wrote:
> +static struct cmdline_info cmdline_msglvl[] = {
> + { "drv", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_DRV,&msglvl_unwanted },
> + { "probe", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_PROBE,&msglvl_unwanted },
> + { "link", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_LINK,&msglvl_unwanted },
> + { "timer", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_TIMER,&msglvl_unwanted },
> + { "ifdown", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_IFDOWN,&msglvl_unwanted },
> + { "ifup", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_IFUP,&msglvl_unwanted },
> + { "rx_err", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_RX_ERR,&msglvl_unwanted },
> + { "tx_err", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_TX_ERR,&msglvl_unwanted },
> + { "tx_queued", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_TX_QUEUED,&msglvl_unwanted },
> + { "intr", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_INTR,&msglvl_unwanted },
> + { "tx_done", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_TX_DONE,&msglvl_unwanted },
> + { "rx_status", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_RX_STATUS,&msglvl_unwanted },
> + { "pktdata", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_PKTDATA,&msglvl_unwanted },
> + { "hw", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_HW,&msglvl_unwanted },
> + { "wol", CMDL_FLAG,&msglvl_wanted, NULL,
> + NETIF_MSG_WOL,&msglvl_unwanted },
A nice improvement over one-variable-per-bit, I think.
applied patches 1-5, thanks!
Jeff
P.S. If you could use my open source email address (jgarzik@pobox.com
or jeff@garzik.org), that would be greatly appreciated. @redhat.com is
only used for sign-offs, as it's less portable than !@redhat.com addresses.
next prev parent reply other threads:[~2010-06-25 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 14:43 [PATCH ethtool 0/5] Fix and enhance command-line parsing Ben Hutchings
2010-06-25 14:46 ` [PATCH ethtool 1/5] ethtool: Parse integers into variables of different sizes and byte orders Ben Hutchings
2010-06-25 14:48 ` [PATCH ethtool 2/5] ethtool: Mark show_usage() as noreturn Ben Hutchings
2010-06-25 14:49 ` [PATCH ethtool 3/5] ethtool: Add support for named flags Ben Hutchings
2010-06-25 14:49 ` [PATCH ethtool 4/5] ethtool: Implement named message type flags Ben Hutchings
2010-06-25 17:11 ` Jeff Garzik [this message]
2010-06-25 14:50 ` [PATCH ethtool 5/5] ethtool: Use named flag support to update extended offload flags Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C24E339.6000606@pobox.com \
--to=jgarzik@pobox.com \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.