From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] block: Implement a blk_yield function to voluntarily give up the I/O scheduler.
Date: Fri, 25 Jun 2010 20:55:00 +0200 [thread overview]
Message-ID: <4C24FB84.5050408@kernel.dk> (raw)
In-Reply-To: <x49bpaznjgx.fsf@segfault.boston.devel.redhat.com>
On 25/06/10 18.51, Jeff Moyer wrote:
>>> + cfq_log_cfqq(cfqd, cfqq, "yielding queue to %d", tsk->pid);
>>> + cfqq->yield_to = new_cic;
>>
>> We are stashing away a pointer to cic without taking reference?
>
> There is no reference counting on the cic.
Not on the cic itself, but on the io context it belongs to. So you
need to grab a reference to that, if you are stowing a reference
to the cic.
--
Jens Axboe
next prev parent reply other threads:[~2010-06-25 18:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 21:34 [PATCH 0/3 v5][RFC] ext3/4: enhance fsync performance when using CFQ Jeff Moyer
2010-06-22 21:35 ` [PATCH 1/3] block: Implement a blk_yield function to voluntarily give up the I/O scheduler Jeff Moyer
2010-06-23 5:04 ` Andrew Morton
2010-06-23 14:50 ` Jeff Moyer
2010-06-24 0:46 ` Vivek Goyal
2010-06-25 16:51 ` Jeff Moyer
2010-06-25 18:55 ` Jens Axboe [this message]
2010-06-25 19:57 ` Jeff Moyer
2010-06-25 20:02 ` Vivek Goyal
2010-06-22 21:35 ` [PATCH 2/3] jbd: yield the device queue when waiting for commits Jeff Moyer
2010-06-22 21:35 ` [PATCH 3/3] jbd2: yield the device queue when waiting for journal commits Jeff Moyer
2010-06-22 22:13 ` [PATCH 0/3 v5][RFC] ext3/4: enhance fsync performance when using CFQ Joel Becker
2010-06-23 9:20 ` Christoph Hellwig
2010-06-23 13:03 ` Jeff Moyer
2010-06-23 9:30 ` Tao Ma
2010-06-23 13:06 ` Jeff Moyer
2010-06-24 5:54 ` Tao Ma
2010-06-24 5:54 ` Tao Ma
2010-06-24 5:54 ` [Ocfs2-devel] " Tao Ma
2010-06-24 14:56 ` Jeff Moyer
2010-06-24 14:56 ` [Ocfs2-devel] " Jeff Moyer
2010-06-27 13:48 ` Jeff Moyer
2010-06-27 13:48 ` [Ocfs2-devel] " Jeff Moyer
2010-06-28 6:41 ` Tao Ma
2010-06-28 6:41 ` Tao Ma
2010-06-28 6:41 ` [Ocfs2-devel] " Tao Ma
2010-06-28 13:58 ` Jeff Moyer
2010-06-28 13:58 ` [Ocfs2-devel] " Jeff Moyer
2010-06-28 23:16 ` Tao Ma
2010-06-28 23:16 ` Tao Ma
2010-06-28 23:16 ` [Ocfs2-devel] " Tao Ma
2010-06-29 14:56 ` Jeff Moyer
2010-06-29 14:56 ` [Ocfs2-devel] " Jeff Moyer
2010-06-30 0:31 ` Tao Ma
2010-06-30 0:31 ` Tao Ma
2010-06-30 0:31 ` [Ocfs2-devel] " Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C24FB84.5050408@kernel.dk \
--to=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.