From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [Patch] USB UHCI portstatus correction
Date: Fri, 25 Jun 2010 21:45:27 +0200 [thread overview]
Message-ID: <4C250757.9030207@gmail.com> (raw)
In-Reply-To: <1277025782.4952.6.camel@pracovna>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On 06/20/2010 11:23 AM, Aleš Nesrsta wrote:
> Hi,
>
> I found some mistake in uhci.c in grub_uhci_portstatus when enable=0.
> There is proposal of correction.
>
> Without correction portstatus reported false timeout when enable=0
> because it is waiting for reset to be done but none is performed...
>
>
This patch seems to change much more that you say. In particular
enable=0 is a request to disable port and you seem to always enable it.
This is likely to break other code.
> Best regards
> Ales
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2010-06-25 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 9:23 [Patch] USB UHCI portstatus correction Aleš Nesrsta
2010-06-25 19:45 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2010-06-25 22:03 ` Aleš Nesrsta
2010-06-28 16:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-07-05 17:12 ` Aleš Nesrsta
2010-07-05 23:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-07-06 17:19 ` Aleš Nesrsta
2010-07-13 10:00 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C250757.9030207@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.