All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, trond.myklebust@fys.uio.no,
	Staubach_Peter@emc.com, bfields@fieldses.org
Subject: Re: [PATCH 1/2] sunrpc: split the vs_hidden flag into TCP and UDP variants (try #2)
Date: Fri, 25 Jun 2010 16:25:42 -0400	[thread overview]
Message-ID: <4C2510C6.902@oracle.com> (raw)
In-Reply-To: <20100625134754.51e313fa@tlielax.poochiereds.net>

On 06/25/10 01:47 PM, Jeff Layton wrote:
> nfsd shares the same sockets between all NFS versions. We can't change
> that since you don't know what NFS version you're getting a call for
> until you read in the data. There's really no way around this.

That is worth mentioning in a documenting comment before nfsd4_dispatch().

I feel that we're adding yet another kludge to the NFSD infrastructure 
to preserve an aging user space API and transport design that was built 
for an era when all NFS versions would always use every transport and 
address family.

I agree with Peter that we should make an effort to use the RPC 
infrastructure as it was intended, in order to advertise the correct 
services and transport capabilities; and update our user space API to 
allow user space to have more fine-grained control over what the kernel 
will advertise and run.  But perhaps that's for another day.

  reply	other threads:[~2010-06-25 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-25 15:49 [PATCH 1/2] sunrpc: split the vs_hidden flag into TCP and UDP variants (try #2) Jeff Layton
2010-06-25 15:49 ` [PATCH 2/2] nfsd: reject NFSv4 requests over UDP Jeff Layton
2010-06-25 15:50 ` [PATCH 1/2] sunrpc: split the vs_hidden flag into TCP and UDP variants (try #2) Chuck Lever
2010-06-25 16:07   ` Jeff Layton
2010-06-25 16:29     ` Chuck Lever
2010-06-25 17:47       ` Jeff Layton
2010-06-25 20:25         ` Chuck Lever [this message]
2010-06-25 22:35           ` Jeff Layton
2010-06-25 16:40     ` Staubach_Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2510C6.902@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=Staubach_Peter@emc.com \
    --cc=bfields@fieldses.org \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.