All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Radensky <felix@embedded-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Link problem with eTSEC2 on P2020RDB
Date: Sat, 26 Jun 2010 13:09:18 +0300	[thread overview]
Message-ID: <4C25D1CE.7090503@embedded-sol.com> (raw)
In-Reply-To: <AANLkTim1RZLAxGsdyvfbYQdQoq4uzY1WP0krxtUSgZHl@mail.gmail.com>

Hi Ben,

On 6/26/2010 8:22 AM, Ben Warren wrote:
> Hi Felix,
>
> On Fri, Jun 25, 2010 at 4:33 AM, Felix Radensky 
> <felix at embedded-sol.com <mailto:felix@embedded-sol.com>> wrote:
>
>     Hi Ben,
>
>     Peter Tyser seems to be OOO until Monday, so maybe you can comment
>     on this problem,
>     as it's network related.
>
>     Peter's patch comes to fix a problem with ethernet not working on
>     XES 8572 board using
>     BCM5482S PHY in SGMII mode.  On the other hand it breaks eTSEC2 on
>     P2020RDB
>     board using VSC8211 PHY in SGMII mode. On P2020RDB not only
>     u-boot, but also
>     Linux cannot use eTSEC2.
>
>
>     Do you have any suggestions how to make both boards happy ?
>
> I'm not familiar with how SGMII is configured on this controller, but 
> it appears that Peter's patch turned of Autonegotiation.  Why this 
> would make a PHY work and a switch not work is curious...

VSC8211 on P2020RDB is a PHY, not a switch. There can be some SGMII 
related problem in MPC8572 that
was fixed in P2020, but it's just a wild guess.

>  Maybe we should have a CONFIG option for SGMII parameters.  Settings 
> could default to the ones Peter set (since he submitted it in November 
> and problems are surfacing now), but could be overriden.  Does that 
> sound reasonable?  Something like:
>
> #ifndef CONFIG TSEC_TBICR_SETTINGS
> #define TBICR_SETTINGS ( \
>                  TBICR_PHY_RESET \
>                  | TBICR_FULL_DUPLEX \
>                  | TBICR_SPEED1_SET \
>                  )
> #else
> #define TBICR_SETTINGS CONFIG_TSEC_TBICR_SETTINGS
> #endif
>
>     Thanks.
>
>     Felix.
>
> If you put together a patch that does this and test it on your board, 
> that should be good enough.  Peter can try it out when he gets back.
>

I'll create a patch based on your suggestion later today or tomorrow and 
test it on P2020RDB and P1020RDB.

Felix.

  reply	other threads:[~2010-06-26 10:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22 20:04 [U-Boot] Link problem with eTSEC2 on P2020RDB Felix Radensky
2010-06-23  6:14 ` André Schwarz
2010-06-23 10:41 ` Aggrwal Poonam-B10812
2010-06-25 11:33 ` Felix Radensky
2010-06-26  5:22   ` Ben Warren
2010-06-26 10:09     ` Felix Radensky [this message]
2010-06-26 13:19     ` Peter Tyser
2010-06-29  7:58       ` Felix Radensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C25D1CE.7090503@embedded-sol.com \
    --to=felix@embedded-sol.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.