Re: [PATCH 2/2] add f_flags to struct statfs(64)

[Tao Ma <tao.ma@oracle.com>]

Hi Christoph,

On 06/26/2010 05:35 PM, Christoph Hellwig wrote:
> Add a flags field to help glibc implementing statvfs(3) efficiently.
>
> We copy the flag values from glibc, and add a new ST_VALID flag to
> denote that f_flags is implemented.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
<snip>
> Index: linux-2.6/include/asm-generic/statfs.h
> ===================================================================
> --- linux-2.6.orig/include/asm-generic/statfs.h	2010-06-26 09:26:56.000000000 +0200
> +++ linux-2.6/include/asm-generic/statfs.h	2010-06-26 10:00:33.868047809 +0200
> @@ -33,7 +33,8 @@ struct statfs {
>   	__kernel_fsid_t f_fsid;
>   	__statfs_word f_namelen;
>   	__statfs_word f_frsize;
> -	__statfs_word f_spare[5];
> +	__statfs_word f_flags;
> +	__statfs_word f_spare[4];
>   };
>
>   /*
> @@ -55,7 +56,8 @@ struct statfs64 {
>   	__kernel_fsid_t f_fsid;
>   	__statfs_word f_namelen;
>   	__statfs_word f_frsize;
> -	__statfs_word f_spare[5];
> +	__statfs_word f_flags;
> +	__statfs_word f_spare[4];
>   } ARCH_PACK_STATFS64;
>
>   /*
> @@ -77,6 +79,7 @@ struct compat_statfs64 {
>   	__kernel_fsid_t f_fsid;
>   	__u32 f_namelen;
>   	__u32 f_frsize;
> +	__u32 f_flags[5];
>   	__u32 f_spare[5];
>   } ARCH_PACK_COMPAT_STATFS64;
This is a typo?

Regards,
Tao