diff for duplicates of <4C285D1C.5060508@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 51ccd0e..2eb9f7f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -40,7 +40,7 @@ Still with the wierd coding style? > + > + list_for_each_entry_safe(pte, tmp, list, list_vpte_long) { > + /* Jump over the helper entry */ -> + if (&pte->list_vpte_long = list) +> + if (&pte->list_vpte_long == list) > + continue; > @@ -78,7 +78,7 @@ the _safe iteration. > + /* Check the list for matching entries */ > + list_for_each_entry_safe(pte, tmp, list, list_pte) { > + /* Jump over the helper entry */ -> + if (&pte->list_pte = list) +> + if (&pte->list_pte == list) > + continue; > @@ -86,7 +86,7 @@ Same here. > + > + /* Invalidate matching PTE */ -> + if ((pte->pte.eaddr& ~0xfffUL) = guest_ea) +> + if ((pte->pte.eaddr& ~0xfffUL) == guest_ea) > + invalidate_pte(vcpu, pte); > + } > + break; @@ -122,7 +122,7 @@ Would be nice to put this block into a function. > + /* Check the list for matching entries */ > + list_for_each_entry_safe(pte, tmp, list, list_vpte) { > + /* Jump over the helper entry */ -> + if (&pte->list_vpte = list) +> + if (&pte->list_vpte == list) > + continue; > @@ -131,7 +131,7 @@ structure. Isn't it multiple hash tables with lists holding matching ptes? > + > + /* Invalidate matching PTEs */ -> + if ((pte->pte.vpage& vp_mask) = guest_vp) +> + if ((pte->pte.vpage& vp_mask) == guest_vp) > + invalidate_pte(vcpu, pte); > + } > +} @@ -151,7 +151,7 @@ structure. Isn't it multiple hash tables with lists holding matching ptes? > + > + list_for_each_entry_safe(pte, tmp, list, list_vpte_long) { > + /* Jump over the helper entry */ -> + if (&pte->list_vpte_long = list) +> + if (&pte->list_vpte_long == list) > + continue; > + > + if ((pte->pte.raddr>= pa_start)&& diff --git a/a/content_digest b/N1/content_digest index ea0c53e..a78ec4e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,12 @@ "ref\01277507817-626-1-git-send-email-agraf@suse.de\0" "ref\01277507817-626-2-git-send-email-agraf@suse.de\0" - "ref\01277507817-626-2-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org\0" "From\0Avi Kivity <avi@redhat.com>\0" "Subject\0Re: [PATCH] KVM: PPC: Add generic hpte management functions\0" - "Date\0Mon, 28 Jun 2010 08:28:12 +0000\0" - "To\0Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>\0" - "Cc\0kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" - KVM list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linuxppc-dev <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>\0" + "Date\0Mon, 28 Jun 2010 11:28:12 +0300\0" + "To\0Alexander Graf <agraf@suse.de>\0" + "Cc\0linuxppc-dev <linuxppc-dev@lists.ozlabs.org>" + KVM list <kvm@vger.kernel.org> + " kvm-ppc@vger.kernel.org\0" "\00:1\0" "b\0" "On 06/26/2010 02:16 AM, Alexander Graf wrote:\n" @@ -52,7 +51,7 @@ "> +\n" "> +\t\tlist_for_each_entry_safe(pte, tmp, list, list_vpte_long) {\n" "> +\t\t\t/* Jump over the helper entry */\n" - "> +\t\t\tif (&pte->list_vpte_long = list)\n" + "> +\t\t\tif (&pte->list_vpte_long == list)\n" "> +\t\t\t\tcontinue;\n" "> \n" "\n" @@ -90,7 +89,7 @@ "> +\t\t/* Check the list for matching entries */\n" "> +\t\tlist_for_each_entry_safe(pte, tmp, list, list_pte) {\n" "> +\t\t\t/* Jump over the helper entry */\n" - "> +\t\t\tif (&pte->list_pte = list)\n" + "> +\t\t\tif (&pte->list_pte == list)\n" "> +\t\t\t\tcontinue;\n" "> \n" "\n" @@ -98,7 +97,7 @@ "\n" "> +\n" "> +\t\t\t/* Invalidate matching PTE */\n" - "> +\t\t\tif ((pte->pte.eaddr& ~0xfffUL) = guest_ea)\n" + "> +\t\t\tif ((pte->pte.eaddr& ~0xfffUL) == guest_ea)\n" "> +\t\t\t\tinvalidate_pte(vcpu, pte);\n" "> +\t\t}\n" "> +\t\tbreak;\n" @@ -134,7 +133,7 @@ "> +\t/* Check the list for matching entries */\n" "> +\tlist_for_each_entry_safe(pte, tmp, list, list_vpte) {\n" "> +\t\t/* Jump over the helper entry */\n" - "> +\t\tif (&pte->list_vpte = list)\n" + "> +\t\tif (&pte->list_vpte == list)\n" "> +\t\t\tcontinue;\n" "> \n" "\n" @@ -143,7 +142,7 @@ "\n" "> +\n" "> +\t\t/* Invalidate matching PTEs */\n" - "> +\t\tif ((pte->pte.vpage& vp_mask) = guest_vp)\n" + "> +\t\tif ((pte->pte.vpage& vp_mask) == guest_vp)\n" "> +\t\t\tinvalidate_pte(vcpu, pte);\n" "> +\t}\n" "> +}\n" @@ -163,7 +162,7 @@ "> +\n" "> +\t\tlist_for_each_entry_safe(pte, tmp, list, list_vpte_long) {\n" "> +\t\t\t/* Jump over the helper entry */\n" - "> +\t\t\tif (&pte->list_vpte_long = list)\n" + "> +\t\t\tif (&pte->list_vpte_long == list)\n" "> +\t\t\t\tcontinue;\n" "> +\n" "> +\t\t\tif ((pte->pte.raddr>= pa_start)&&\n" @@ -222,4 +221,4 @@ "-- \n" error compiling committee.c: too many arguments to function -ce3d0a0275c44fae961f836ba85580ae802a357d8a0c731f8167e55a7c5f9b2a +4434534044232bb09176ac98550cdf220a91fa26262a49798b9ae2c7485babb4
diff --git a/a/1.txt b/N2/1.txt index 51ccd0e..2eb9f7f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -40,7 +40,7 @@ Still with the wierd coding style? > + > + list_for_each_entry_safe(pte, tmp, list, list_vpte_long) { > + /* Jump over the helper entry */ -> + if (&pte->list_vpte_long = list) +> + if (&pte->list_vpte_long == list) > + continue; > @@ -78,7 +78,7 @@ the _safe iteration. > + /* Check the list for matching entries */ > + list_for_each_entry_safe(pte, tmp, list, list_pte) { > + /* Jump over the helper entry */ -> + if (&pte->list_pte = list) +> + if (&pte->list_pte == list) > + continue; > @@ -86,7 +86,7 @@ Same here. > + > + /* Invalidate matching PTE */ -> + if ((pte->pte.eaddr& ~0xfffUL) = guest_ea) +> + if ((pte->pte.eaddr& ~0xfffUL) == guest_ea) > + invalidate_pte(vcpu, pte); > + } > + break; @@ -122,7 +122,7 @@ Would be nice to put this block into a function. > + /* Check the list for matching entries */ > + list_for_each_entry_safe(pte, tmp, list, list_vpte) { > + /* Jump over the helper entry */ -> + if (&pte->list_vpte = list) +> + if (&pte->list_vpte == list) > + continue; > @@ -131,7 +131,7 @@ structure. Isn't it multiple hash tables with lists holding matching ptes? > + > + /* Invalidate matching PTEs */ -> + if ((pte->pte.vpage& vp_mask) = guest_vp) +> + if ((pte->pte.vpage& vp_mask) == guest_vp) > + invalidate_pte(vcpu, pte); > + } > +} @@ -151,7 +151,7 @@ structure. Isn't it multiple hash tables with lists holding matching ptes? > + > + list_for_each_entry_safe(pte, tmp, list, list_vpte_long) { > + /* Jump over the helper entry */ -> + if (&pte->list_vpte_long = list) +> + if (&pte->list_vpte_long == list) > + continue; > + > + if ((pte->pte.raddr>= pa_start)&& diff --git a/a/content_digest b/N2/content_digest index ea0c53e..1648323 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,9 +1,9 @@ "ref\01277507817-626-1-git-send-email-agraf@suse.de\0" "ref\01277507817-626-2-git-send-email-agraf@suse.de\0" "ref\01277507817-626-2-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org\0" - "From\0Avi Kivity <avi@redhat.com>\0" + "From\0Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\0" "Subject\0Re: [PATCH] KVM: PPC: Add generic hpte management functions\0" - "Date\0Mon, 28 Jun 2010 08:28:12 +0000\0" + "Date\0Mon, 28 Jun 2010 11:28:12 +0300\0" "To\0Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>\0" "Cc\0kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" KVM list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> @@ -52,7 +52,7 @@ "> +\n" "> +\t\tlist_for_each_entry_safe(pte, tmp, list, list_vpte_long) {\n" "> +\t\t\t/* Jump over the helper entry */\n" - "> +\t\t\tif (&pte->list_vpte_long = list)\n" + "> +\t\t\tif (&pte->list_vpte_long == list)\n" "> +\t\t\t\tcontinue;\n" "> \n" "\n" @@ -90,7 +90,7 @@ "> +\t\t/* Check the list for matching entries */\n" "> +\t\tlist_for_each_entry_safe(pte, tmp, list, list_pte) {\n" "> +\t\t\t/* Jump over the helper entry */\n" - "> +\t\t\tif (&pte->list_pte = list)\n" + "> +\t\t\tif (&pte->list_pte == list)\n" "> +\t\t\t\tcontinue;\n" "> \n" "\n" @@ -98,7 +98,7 @@ "\n" "> +\n" "> +\t\t\t/* Invalidate matching PTE */\n" - "> +\t\t\tif ((pte->pte.eaddr& ~0xfffUL) = guest_ea)\n" + "> +\t\t\tif ((pte->pte.eaddr& ~0xfffUL) == guest_ea)\n" "> +\t\t\t\tinvalidate_pte(vcpu, pte);\n" "> +\t\t}\n" "> +\t\tbreak;\n" @@ -134,7 +134,7 @@ "> +\t/* Check the list for matching entries */\n" "> +\tlist_for_each_entry_safe(pte, tmp, list, list_vpte) {\n" "> +\t\t/* Jump over the helper entry */\n" - "> +\t\tif (&pte->list_vpte = list)\n" + "> +\t\tif (&pte->list_vpte == list)\n" "> +\t\t\tcontinue;\n" "> \n" "\n" @@ -143,7 +143,7 @@ "\n" "> +\n" "> +\t\t/* Invalidate matching PTEs */\n" - "> +\t\tif ((pte->pte.vpage& vp_mask) = guest_vp)\n" + "> +\t\tif ((pte->pte.vpage& vp_mask) == guest_vp)\n" "> +\t\t\tinvalidate_pte(vcpu, pte);\n" "> +\t}\n" "> +}\n" @@ -163,7 +163,7 @@ "> +\n" "> +\t\tlist_for_each_entry_safe(pte, tmp, list, list_vpte_long) {\n" "> +\t\t\t/* Jump over the helper entry */\n" - "> +\t\t\tif (&pte->list_vpte_long = list)\n" + "> +\t\t\tif (&pte->list_vpte_long == list)\n" "> +\t\t\t\tcontinue;\n" "> +\n" "> +\t\t\tif ((pte->pte.raddr>= pa_start)&&\n" @@ -222,4 +222,4 @@ "-- \n" error compiling committee.c: too many arguments to function -ce3d0a0275c44fae961f836ba85580ae802a357d8a0c731f8167e55a7c5f9b2a +3aea31e166f01a7aae9bb9616dfa6f0b55e5f53a5174a5f351e79c20d7095635
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.