From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver Date: Mon, 28 Jun 2010 17:39:39 +0900 Message-ID: <4C285FCB.3070100@samsung.com> References: <1277101605-2435-1-git-send-email-jy0922.shim@samsung.com> <1277101605-2435-3-git-send-email-jy0922.shim@samsung.com> <20100625083019.GD8546@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20100625083019.GD8546@core.coreip.homeip.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dmitry Torokhov Cc: kgene.kim@samsung.com, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org Hi, Dmitry. On 6/25/2010 5:30 PM, Dmitry Torokhov wrote: > Hi Joonyoung, > > On Mon, Jun 21, 2010 at 03:26:45PM +0900, Joonyoung Shim wrote: >> This patch adds support for keypad driver running on Samsung cpus. This >> driver is tested on GONI and Aquila board using S5PC110 cpu. >> >> Signed-off-by: Joonyoung Shim >> Signed-off-by: Kyungmin Park > > Following my conversation with Thomas Gleixner reagrding "long playing" > threaded interrupt handlers I tried to convert your driver to use this > concept. The idea is to keep polling within IRQ thread context instead > of using additional work/timer structures to simplify code and ensure > race-free shutdown/unbind. > > I think it was based on v4 of your driver and I'd appreciate if you could > give it a try. > > Thank you. > I have tested your patch on my v5 patchset and it is working after some fixing. I will post v6 patchset appling your patch. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jy0922.shim@samsung.com (Joonyoung Shim) Date: Mon, 28 Jun 2010 17:39:39 +0900 Subject: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver In-Reply-To: <20100625083019.GD8546@core.coreip.homeip.net> References: <1277101605-2435-1-git-send-email-jy0922.shim@samsung.com> <1277101605-2435-3-git-send-email-jy0922.shim@samsung.com> <20100625083019.GD8546@core.coreip.homeip.net> Message-ID: <4C285FCB.3070100@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Dmitry. On 6/25/2010 5:30 PM, Dmitry Torokhov wrote: > Hi Joonyoung, > > On Mon, Jun 21, 2010 at 03:26:45PM +0900, Joonyoung Shim wrote: >> This patch adds support for keypad driver running on Samsung cpus. This >> driver is tested on GONI and Aquila board using S5PC110 cpu. >> >> Signed-off-by: Joonyoung Shim >> Signed-off-by: Kyungmin Park > > Following my conversation with Thomas Gleixner reagrding "long playing" > threaded interrupt handlers I tried to convert your driver to use this > concept. The idea is to keep polling within IRQ thread context instead > of using additional work/timer structures to simplify code and ensure > race-free shutdown/unbind. > > I think it was based on v4 of your driver and I'd appreciate if you could > give it a try. > > Thank you. > I have tested your patch on my v5 patchset and it is working after some fixing. I will post v6 patchset appling your patch. Thanks.