All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx
Date: Mon, 28 Jun 2010 17:25:35 +0800	[thread overview]
Message-ID: <4C286A8F.9080508@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1006280207580.28072@chino.kir.corp.google.com>

On 06/28/10 17:08, David Rientjes wrote:
> On Sun, 27 Jun 2010, Amerigo Wang wrote:
>
>> From: Amerigo Wang<amwang@redhat.com>
>> Date: Mon, 28 Jun 2010 10:42:28 +0800
>>
>> When I use make LOCALVERSION=local and LOCALVERSION_AUTO is not set,
>> I got "2.6.35-rc3local". It is supposed to be "2.6.35-rc3-local".
>>
>
> No, a `-' is not implied when using LOCALVERSION=.

But in your patch description, you said:

     Without CONFIG_LOCALVERSION_AUTO, "make" results in v2.6.32-rc4+
     unless the repository is at the Linux v2.6.32-rc4 commit (in which
     case the version would be v2.6.32-rc4).  If "make LOCALVERSION=kbuild"
     were used, it results in v2.6.32-rc4-kbuild.

So, shouldn't that be "make LOCALVERSION=-kbuild"?

Thanks.


  reply	other threads:[~2010-06-28  9:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-28  3:00 [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx Amerigo Wang
2010-06-28  3:01 ` [PATCH 2/2] Makefile: "make kernelrelease" should show the correct full kernel version Amerigo Wang
2010-06-29 12:13   ` Michal Marek
2010-06-29 12:13     ` Michal Marek
2010-06-29 12:17     ` Michal Marek
2010-06-30 10:39     ` Cong Wang
2010-08-18  7:15   ` Brice Goglin
2010-08-18  8:10     ` Cong Wang
2010-08-18  8:38       ` Brice Goglin
2010-08-18  8:57         ` Cong Wang
2010-08-18  8:52           ` Brice Goglin
2010-08-18  9:20             ` Cong Wang
2010-08-18  9:17               ` Brice Goglin
2010-06-28  9:08 ` [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx David Rientjes
2010-06-28  9:25   ` Cong Wang [this message]
2010-06-28 18:46     ` David Rientjes
2010-06-29  1:45       ` Cong Wang
2010-06-29 12:14       ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C286A8F.9080508@redhat.com \
    --to=amwang@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.