From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Gardner Subject: Re: Regression caused by commit cc56f7de7f00d188c7c4da1e9861581853b9e92f Date: Mon, 28 Jun 2010 07:53:57 -0600 Message-ID: <4C28A975.1040709@canonical.com> References: <4C250F2F.8000206@canonical.com> Reply-To: tim.gardner@canonical.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, Miklos Szeredi , Jens Axboe To: Changli Gao Return-path: Received: from mail.tpi.com ([70.99.223.143]:3796 "EHLO mail.tpi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391Ab0F1NyP (ORCPT ); Mon, 28 Jun 2010 09:54:15 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 06/27/2010 09:11 PM, Changli Gao wrote: > On Sat, Jun 26, 2010 at 4:18 AM, Tim Gardner wrote: >> Fat fingered the original email and didn't get the fsdevel address correct. >> >> ----------------------- >> Hi, >> >> I have bisected a strange regression down to this commit that you made. If I >> apply the attached patch (which restores the original 2 lines of code), then >> everything works correctly. I apologize, but I don't have a simple >> reproducer. The gist of the problem is that Java cannot decrypt a file under >> certain circumstances, e.g., "ERROR javax.crypto.BadPaddingException: pad >> block corrupted". There is more information in the bug report at >> http://bugs.launchpad.net/bugs/588861 , but not all of it is helpful. >> >> Any thoughts? >> > > It seems the target of sendfile(2) isn't a socket, and the current > sendfile(2) code can't handle non-socket target correctly. Please try > this patch: http://marc.info/?l=linux-fsdevel&m=127488508224173&w=2 . > Thanks - this patch appears to have fixed 'pad block corrupted' error. Is it queued for 2.6.35-rc4 ? rtg -- Tim Gardner tim.gardner@canonical.com