From: "Justin P. Mattock" <justinmattock@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, sds@tycho.nsa.gov, lenb@kernel.org,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used
Date: Mon, 28 Jun 2010 10:48:23 -0700 [thread overview]
Message-ID: <4C28E067.6070004@gmail.com> (raw)
In-Reply-To: <5104.1277728717@redhat.com>
On 06/28/2010 05:38 AM, David Howells wrote:
> Justin P. Mattock<justinmattock@gmail.com> wrote:
>
>> In this case the safest approach(in my mind) would be to just
>> mark the integer __unused. Keep in mind though Im not certain
>> if this is the right place for this value i.e. will this effect
>> *instkey or not(please check).
>
> This is the wrong approach. Either the variable should be got rid of, or it
> should be used to replace all the other calls to key_ref_to_ptr() in
> keyctl_describe_key().
>
> David
>
I see your patch you sent for this.. vary nice!
Thanks!
Justin P. Mattock
next prev parent reply other threads:[~2010-06-28 17:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-27 6:47 [PATCH 0/5] Fix gcc 4.6.0 set but unused variable warnings Justin P. Mattock
2010-06-27 6:47 ` [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used Justin P. Mattock
2010-06-28 12:38 ` David Howells
2010-06-28 17:48 ` Justin P. Mattock [this message]
2010-06-28 13:05 ` [PATCH] KEYS: Use the variable 'key' in keyctl_describe_key() David Howells
2010-06-28 23:01 ` [Keyrings] " James Morris
2010-06-27 6:47 ` [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e_sft' set but not used Justin P. Mattock
2010-06-28 12:44 ` David Howells
2010-06-28 17:49 ` Justin P. Mattock
2010-06-27 6:47 ` [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' " Justin P. Mattock
2010-06-28 12:48 ` David Howells
2010-06-28 17:52 ` Justin P. Mattock
2010-06-28 18:47 ` David Howells
2010-06-28 19:03 ` Justin P. Mattock
2010-06-29 3:23 ` Justin P. Mattock
2010-06-29 15:47 ` David Howells
2010-06-29 17:14 ` Justin P. Mattock
2010-06-29 21:53 ` Justin P. Mattock
2010-06-30 9:13 ` David Howells
2010-06-30 13:21 ` Justin P. Mattock
2010-06-30 19:47 ` Justin P. Mattock
2010-07-01 9:31 ` David Howells
2010-07-01 13:41 ` Justin P. Mattock
2010-07-01 20:01 ` Justin P. Mattock
2010-07-02 0:10 ` David Howells
2010-07-02 0:59 ` Justin P. Mattock
2010-06-28 19:08 ` Justin P. Mattock
2010-06-27 6:47 ` [PATCH 4/5]block:cryptoloop Fix warning: variable 'cipher' " Justin P. Mattock
2010-06-28 12:49 ` David Howells
2010-06-27 6:47 ` [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq_txseq' may be undefined Justin P. Mattock
2010-06-27 7:31 ` Gustavo F. Padovan
2010-06-28 12:52 ` David Howells
2010-06-28 13:02 ` Bernd Petrovitsch
2010-06-28 17:56 ` Justin P. Mattock
2010-06-28 12:57 ` [PATCH] Bluetooth: Fix abuse of the preincrement operator David Howells
2010-06-28 13:12 ` Gustavo F. Padovan
2010-06-30 20:10 ` David Miller
2010-06-28 17:44 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C28E067.6070004@gmail.com \
--to=justinmattock@gmail.com \
--cc=dhowells@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.