From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH]libxc: fix a Segmentation fault
Date: Tue, 29 Jun 2010 08:40:21 +0800
Message-ID: <4C2940F5.5030603@cn.fujitsu.com>
References: <4C284523.4000304@cn.fujitsu.com>
	<19496.50624.967390.571291@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19496.50624.967390.571291@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 06/28/2010 11:54 PM, Ian Jackson wrote:
> Yang Hongyang writes ("[Xen-devel] [PATCH]libxc: fix a Segmentation fault"):
>> # xl list
>> xc: error: Could not obtain handle on privileged command interface (2 = No such file or directory): Internal error
>> Segmentation fault
>>
>> This is because xc free the logger which xl created.
> 
> Well spotted.  You're right about the cause, but your fix is not
> correct.  The correct fix is that xc_interface_open's error path
> should free error_handler_tofree rather than error_handler.  So there
> is no need to add another variable.  I will apply that fix.
> 

OK,Thanks Ian.

> Thanks,
> Ian.
> 
> 


-- 
Regards
Yang Hongyang