From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 1/10] KVM: MMU: fix writable sync sp mapping
Date: Tue, 29 Jun 2010 09:19:26 +0800 [thread overview]
Message-ID: <4C294A1E.1070602@cn.fujitsu.com> (raw)
In-Reply-To: <4C288A6E.6060500@redhat.com>
Avi Kivity wrote:
>
>
> I think I see. So, after A, the pages are write protected, but are
> still marked as unsync. In B, we're testing SP2->unsync, which we plan
> to sync soon, but haven't yet. So the test for s->unsync is incorrect.
>
Right.
> So the patch is right. Thanks for the explanation. Please update the
> changelog to note that sp->unsync is not reliable during resync, this is
> tricky stuff.
>
OK, will do it in the next version.
prev parent reply other threads:[~2010-06-29 1:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 12:05 [PATCH v2 1/10] KVM: MMU: fix writable sync sp mapping Xiao Guangrong
2010-06-27 7:59 ` Xiao Guangrong
2010-06-28 9:18 ` Avi Kivity
2010-06-28 9:40 ` Xiao Guangrong
2010-06-28 11:41 ` Avi Kivity
2010-06-29 1:19 ` Xiao Guangrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C294A1E.1070602@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.