All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Ware <mware@elphinstone.net>
To: dedekind1@gmail.com
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-mtd@lists.infradead.org
Subject: Re: [RFC/PATCH] doc2000: Fix uninitialized variable in	doc_ecc_decode()
Date: Tue, 29 Jun 2010 16:47:03 +1000	[thread overview]
Message-ID: <4C2996E7.9040209@elphinstone.net> (raw)
In-Reply-To: <1277792986.1041.959.camel@localhost>

On 29/06/10 16:29, Artem Bityutskiy wrote:
> On Thu, 2010-05-27 at 11:45 +1000, Mark Ware wrote:
>> The variable 'syn' was being used uninitialized.  Also
>> fixed incorrect use of syn[] vs s[].
>>
>> Tested on powerpc board with 64MB DOC2000.
>> ---
>>
>> I am porting from a 2.4.18 kernel to 2.6.32, and I saw random media header
>> mismatches causing a failure to detect the DOC device partitions.  Tracing
>> through, I saw this variable being used uninitialized and I suspect
>> incorrectly also.
>>
>> I do not really understand how the ecc/syndrome code works, so I do not
>> know if this patch is the correct solution, but it did make my problem
>> go away...
>>
>> CC: Thomas Gleixner as I believe he may have written this function initially.
> 
> Please, always add Signed-off-by for kernel patches. I added it for you.
> 

Thanks.  I guess I expected to be told that I was smoking something and that
my DOC error disappearing was unrelated...

Mark

  reply	other threads:[~2010-06-29  6:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27  1:45 [RFC/PATCH] doc2000: Fix uninitialized variable in doc_ecc_decode() Mark Ware
2010-06-17  4:44 ` Mark Ware
2010-06-29  3:46 ` Artem Bityutskiy
2010-06-29  3:58   ` Artem Bityutskiy
2010-06-29  6:29 ` Artem Bityutskiy
2010-06-29  6:47   ` Mark Ware [this message]
2010-06-29  6:50     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2996E7.9040209@elphinstone.net \
    --to=mware@elphinstone.net \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.