From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 29 Jun 2010 12:56:52 +0000 Subject: Re: [PATCH] KVM: PPC: Add generic hpte management functions Message-Id: <4C29ED94.6060904@suse.de> List-Id: References: <1277507817-626-1-git-send-email-agraf@suse.de> <1277507817-626-2-git-send-email-agraf@suse.de> <4C285D1C.5060508@redhat.com> <20417D40-9345-485B-9201-8B3722B7457F@suse.de> <4C286770.6010204@redhat.com> In-Reply-To: <4C286770.6010204-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Avi Kivity Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, KVM list , linuxppc-dev Avi Kivity wrote: > On 06/28/2010 11:55 AM, Alexander Graf wrote: >> >>>> + >>>> +static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) { >>>> + return hash_64(eaddr>> PTE_SIZE, HPTEG_HASH_BITS_PTE); >>>> +} >>>> + >>>> +static inline u64 kvmppc_mmu_hash_vpte(u64 vpage) { >>>> + return hash_64(vpage& 0xfffffffffULL, HPTEG_HASH_BITS_VPTE); >>>> +} >>>> + >>>> +static inline u64 kvmppc_mmu_hash_vpte_long(u64 vpage) { >>>> + return hash_64((vpage& 0xffffff000ULL)>> 12, >>>> + HPTEG_HASH_BITS_VPTE_LONG); >>>> +} >>>> >>>> >>> Still with the wierd coding style? >>> >> Not sure what's going on there. My editor displays it normally. Weird. >> > > Try hitting 'save'. hexdump -C on the respective section in the exact patch file I submitted above shows: 00000a80 75 72 6e 20 68 61 73 68 5f 36 34 28 65 61 64 64 |urn hash_64(eadd| 00000a90 72 20 3e 3e 20 50 54 45 5f 53 49 5a 45 2c 20 48 |r >> PTE_SIZE, H| Maybe your mail client breaks it? Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.suse.de", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 070B0B6EF2 for ; Tue, 29 Jun 2010 22:56:58 +1000 (EST) Message-ID: <4C29ED94.6060904@suse.de> Date: Tue, 29 Jun 2010 14:56:52 +0200 From: Alexander Graf MIME-Version: 1.0 To: Avi Kivity Subject: Re: [PATCH] KVM: PPC: Add generic hpte management functions References: <1277507817-626-1-git-send-email-agraf@suse.de> <1277507817-626-2-git-send-email-agraf@suse.de> <4C285D1C.5060508@redhat.com> <20417D40-9345-485B-9201-8B3722B7457F@suse.de> <4C286770.6010204@redhat.com> In-Reply-To: <4C286770.6010204@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev , KVM list , kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Avi Kivity wrote: > On 06/28/2010 11:55 AM, Alexander Graf wrote: >> >>>> + >>>> +static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) { >>>> + return hash_64(eaddr>> PTE_SIZE, HPTEG_HASH_BITS_PTE); >>>> +} >>>> + >>>> +static inline u64 kvmppc_mmu_hash_vpte(u64 vpage) { >>>> + return hash_64(vpage& 0xfffffffffULL, HPTEG_HASH_BITS_VPTE); >>>> +} >>>> + >>>> +static inline u64 kvmppc_mmu_hash_vpte_long(u64 vpage) { >>>> + return hash_64((vpage& 0xffffff000ULL)>> 12, >>>> + HPTEG_HASH_BITS_VPTE_LONG); >>>> +} >>>> >>>> >>> Still with the wierd coding style? >>> >> Not sure what's going on there. My editor displays it normally. Weird. >> > > Try hitting 'save'. hexdump -C on the respective section in the exact patch file I submitted above shows: 00000a80 75 72 6e 20 68 61 73 68 5f 36 34 28 65 61 64 64 |urn hash_64(eadd| 00000a90 72 20 3e 3e 20 50 54 45 5f 53 49 5a 45 2c 20 48 |r >> PTE_SIZE, H| Maybe your mail client breaks it? Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] KVM: PPC: Add generic hpte management functions Date: Tue, 29 Jun 2010 14:56:52 +0200 Message-ID: <4C29ED94.6060904@suse.de> References: <1277507817-626-1-git-send-email-agraf@suse.de> <1277507817-626-2-git-send-email-agraf@suse.de> <4C285D1C.5060508@redhat.com> <20417D40-9345-485B-9201-8B3722B7457F@suse.de> <4C286770.6010204@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, KVM list , linuxppc-dev To: Avi Kivity Return-path: In-Reply-To: <4C286770.6010204-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > On 06/28/2010 11:55 AM, Alexander Graf wrote: >> >>>> + >>>> +static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) { >>>> + return hash_64(eaddr>> PTE_SIZE, HPTEG_HASH_BITS_PTE); >>>> +} >>>> + >>>> +static inline u64 kvmppc_mmu_hash_vpte(u64 vpage) { >>>> + return hash_64(vpage& 0xfffffffffULL, HPTEG_HASH_BITS_VPTE); >>>> +} >>>> + >>>> +static inline u64 kvmppc_mmu_hash_vpte_long(u64 vpage) { >>>> + return hash_64((vpage& 0xffffff000ULL)>> 12, >>>> + HPTEG_HASH_BITS_VPTE_LONG); >>>> +} >>>> >>>> >>> Still with the wierd coding style? >>> >> Not sure what's going on there. My editor displays it normally. Weird. >> > > Try hitting 'save'. hexdump -C on the respective section in the exact patch file I submitted above shows: 00000a80 75 72 6e 20 68 61 73 68 5f 36 34 28 65 61 64 64 |urn hash_64(eadd| 00000a90 72 20 3e 3e 20 50 54 45 5f 53 49 5a 45 2c 20 48 |r >> PTE_SIZE, H| Maybe your mail client breaks it? Alex