From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Novotny Subject: Re: [PATCH] pyGrub: Fix default when out of range Date: Tue, 29 Jun 2010 16:24:23 +0200 Message-ID: <4C2A0217.7030404@redhat.com> References: <4C28DB37.1020100@redhat.com> <19497.64281.830946.672157@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19497.64281.830946.672157@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org On 06/29/2010 03:54 PM, Ian Jackson wrote: > Michal Novotny writes ("[Xen-devel] [PATCH] pyGrub: Fix default when out of range"): > >> this is the patch to fix pyGrub default value when it's being set out of >> range. This patch makes the quiet and interactive mode select the same >> default image when the default value for boot entry is out of range, >> i.e. when the guest is having wrong configuration in it's boot loader >> (like 3 entries with default mistakenly set to 10 etc). >> > I'm not sure this is right. What does grub proper do with invalid > defaults ? Is it really correct to blunder on and just use the first > one as a default ? > > Sorry to quibble. > > Ian. > Hi Ian, I did try it using the real (bare-metal) grub 0.97 (in RHEL-5) to set the default out of range and it was set to the first entry so it matches the bare-metal grub behavior now. So the quiet mode was having it right all the time but interactive mode didn't so this is basically fix for interactive mode of pygrub. Michal -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat