From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 2 of 2] xencommons: Wait for xenstored to
	start	before setting dom0 name
Date: Tue, 29 Jun 2010 16:37:38 +0200
Message-ID: <4C2A0532.2040602@goop.org>
References: <patchbomb.1277819804@gdunlap-desktop>
	<dc49f02fc463ab48c82a.1277819806@gdunlap-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <dc49f02fc463ab48c82a.1277819806@gdunlap-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Vincent Hanquez <Vincent.Hanquez@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 06/29/2010 03:56 PM, George Dunlap wrote:
> On one of my boxes, the xenstore-write setting dom0's name starts
> before xenstored is actually ready to handle the connection properly,
> resulting in the name set failing.  Wait for xenstored to be up and
> responding to reads before continuing, timing out after 30 seconds.
>
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>
> diff -r ad0f9cc72415 -r dc49f02fc463 tools/hotplug/Linux/init.d/xencommons
> --- a/tools/hotplug/Linux/init.d/xencommons	Tue Jun 29 14:56:28 2010 +0100
> +++ b/tools/hotplug/Linux/init.d/xencommons	Tue Jun 29 14:56:28 2010 +0100
> @@ -37,14 +37,32 @@
>  fi
>  
>  do_start () {
> +        local time=0
> +	local timeout=30
> +
>  	if ! `xenstore-read -s / >/dev/null 2>&1`
>  	then
>  		test -z "$XENSTORED_ROOTDIR" || XENSTORED_ROOTDIR="/var/lib/xenstored"
>  		rm -f "$XENSTORED_ROOTDIR"/tdb* &>/dev/null
>  		test -z "$XENSTORED_TRACE" || XENSTORED_ARGS=" -T /var/log/xen/xenstored-trace.log"
>  
> -		echo Starting xenstored...
> +		echo -n Starting xenstored...
>  		xenstored --pid-file=/var/run/xenstore.pid $XENSTORED_ARGS
>   

Why isn't xenstored ready by the time the main process exits?  Seems
like a bug in xenstored. Does oxenstored get this right?

    J


> +
> +		# Wait for xenstored to actually come up, timing out after 30 seconds
> +                while [ $time -lt $timeout ] && ! `xenstore-read -s / >/dev/null 2>&1` ; do
> +                    echo -n .
> +		    time=$(($time+1))
> +                    sleep 1
> +                done
> +		echo
> +
> +		# Exit if we timed out
> +		if ! [ $time -lt $timeout ] ; then
> +		    echo Could not start xenstored
> +		    exit 1
> +		fi
> +
>  		echo Setting domain 0 name...
>  		xenstore-write "/local/domain/0/name" "Domain-0"
>  	fi
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>