All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Meyer <reinhard.meyer@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] AT91SAM9 series - cleanup USART definitions
Date: Tue, 29 Jun 2010 23:03:59 +0200	[thread overview]
Message-ID: <4C2A5FBF.1000907@emk-elektronik.de> (raw)
In-Reply-To: <4C2A5BA5.20809@emk-elektronik.de>

Reinhard Meyer wrote:
> Hello Wolfgang,
>
> I just became aware that this patch will involve changes to ALL 
> include/configs/*.h files for AT91 AND AVR32 boards using 
> atmel_usart.c. If thats OK I will do that.
>
Reason:

#if defined(CONFIG_USART0)
# define USART_ID    0
# define USART_BASE    USART0_BASE
#elif defined(CONFIG_USART1)
# define USART_ID    1
# define USART_BASE    USART1_BASE
#elif defined(CONFIG_USART2)
# define USART_ID    2
# define USART_BASE    USART2_BASE
#elif defined(CONFIG_USART3)
# define USART_ID    3
# define USART_BASE    USART3_BASE
#endif

in atmel_usart.c would have to be blown up for each "new" USART 
incarnation Atmel invents on new SoCs.
USART_ID is effectively not used
and USART_BASE might as well defined directly in the 
include/configs/<board>.h file either by:

#define CONFIG_ATMEL_USART    1
#define CONFIG_ATMEL_USART_BASE AT91_UARTDEB /* USART used is DBGU */

OR directly by:

#define CONFIG_ATMEL_USART AT91_UARTDEB /* USART used is DBGU */

or is the 2nd solution bad because Makefiles might choke on it?

Greetings, Reinhard

      reply	other threads:[~2010-06-29 21:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 18:32 [U-Boot] [RFC] AT91SAM9 series - cleanup USART definitions Reinhard Meyer
2010-06-29 19:17 ` Wolfgang Denk
2010-06-29 20:46   ` Reinhard Meyer
2010-06-29 21:03     ` Reinhard Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2A5FBF.1000907@emk-elektronik.de \
    --to=reinhard.meyer@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.