From: Mike Rapoport <mike@compulab.co.il>
To: Tony Lindgren <tony@atomide.com>
Cc: Sergio Aguirre <saaguirre@ti.com>,
linux-omap@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Mike Rapoport <mike@compulab.co.il>
Subject: Re: [RFC][PATCH] omap3: Unify omap2_set_globals_3[43,6x]x functions
Date: Wed, 30 Jun 2010 10:04:48 +0300 [thread overview]
Message-ID: <4C2AEC90.2050709@compulab.co.il> (raw)
In-Reply-To: <20100630063646.GS2822@atomide.com>
Tony Lindgren wrote:
> * Mike Rapoport <mike@compulab.co.il> [100630 08:20]:
>> Sergio Aguirre wrote:
>>> The only difference between them is the physical address of the
>>> uart4 port, which is only present in 36xx chips.
>>>
>>> We don't really need to care about keeping these 2 functions, since
>>> the decision to use uart4 is more cleanly done later when we do have
>>> access to omap_revision variable.
>>>
>>> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
>>> ---
>>> arch/arm/mach-omap2/board-3430sdp.c | 2 +-
>>> arch/arm/mach-omap2/board-3630sdp.c | 2 +-
>>> arch/arm/mach-omap2/board-am3517evm.c | 2 +-
>>> arch/arm/mach-omap2/board-cm-t35.c | 2 +-
>>> arch/arm/mach-omap2/board-devkit8000.c | 2 +-
>>> arch/arm/mach-omap2/board-igep0020.c | 2 +-
>>> arch/arm/mach-omap2/board-ldp.c | 2 +-
>>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
>>> arch/arm/mach-omap2/board-omap3evm.c | 2 +-
>>> arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
>>> arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
>>> arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
>>> arch/arm/mach-omap2/board-overo.c | 2 +-
>>> arch/arm/mach-omap2/board-rx51.c | 2 +-
>>> arch/arm/mach-omap2/board-zoom2.c | 2 +-
>>> arch/arm/mach-omap2/board-zoom3.c | 2 +-
>>> arch/arm/plat-omap/common.c | 10 ++--------
>>> arch/arm/plat-omap/include/plat/common.h | 3 +--
>>> 18 files changed, 19 insertions(+), 26 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
>>> index dd9c031..4961f3b 100644
>>> --- a/arch/arm/mach-omap2/board-3430sdp.c
>>> +++ b/arch/arm/mach-omap2/board-3430sdp.c
>>> @@ -805,7 +805,7 @@ static void __init omap_3430sdp_init(void)
>>> static void __init omap_3430sdp_map_io(void)
>>> {
>>> - omap2_set_globals_343x();
>>> + omap2_set_globals_3xxx();
>>> omap34xx_map_common_io();
>>> }
>> Maybe we should take it one step further and replace board_map_io
>> functions with common omap3_map_io?
>
> Could be done yeah. If special handling is needed, it can still
> be done in the board-*.c files. Care to do a patch for that?
no problem.
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2010-06-30 7:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 20:30 [RFC][PATCH] omap3: Unify omap2_set_globals_3[43,6x]x functions Sergio Aguirre
2010-06-29 22:24 ` Kevin Hilman
2010-07-07 10:34 ` Tony Lindgren
2010-06-30 5:25 ` Mike Rapoport
2010-06-30 6:36 ` Tony Lindgren
2010-06-30 7:04 ` Mike Rapoport [this message]
2010-06-30 8:47 ` [PATCH] omap3: introduce omap3_map_io Mike Rapoport
2010-07-07 10:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2AEC90.2050709@compulab.co.il \
--to=mike@compulab.co.il \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=saaguirre@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.