All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
To: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
	Amit Nagal <helloin.amit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Antonio Ospite
	<ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>
Subject: Re: Report ID problem with HID-RAW interface usage
Date: Wed, 30 Jun 2010 08:32:22 -0400	[thread overview]
Message-ID: <4C2B3956.6080107@signal11.us> (raw)
In-Reply-To: <alpine.LNX.2.00.1006301252380.13809-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>


>> 2)
>>
>> ioctl  which sets a flag so that when device sends a report , report
>> id&  report type  is prefixed
>> to output of read() .
>> i mean when application calls read , it gets input report as<report
>> id><report type><payload>
>> right now we get<payload>  only .
>>      
> Please see the commit 5a38f2c7c4dd53d5be097930902c108e362584a3. That makes
> sure that report id should be there properly. Do you still see any problem
> with this commit applied? (2.6.34 is the first kernel to have this one).
>    

That commit removes an extra byte from the beginning of reports handed 
to read(). If I understand correctly, it doesn't do what he's asking.

For devices which use numbered reports, reports which come from read() 
have the report ID at the beginning, in the form:
<report_id><payload>

For devices which do _not_ use numbered reports, only the payload is 
sent. Of course, since the device only uses a single report, a report 
number does not even make sense, and is not needed, since you know which 
report it is (as there is only one). The form is:
<payload>

It is not necessary to return the report type, because the read() 
interface will only give you INPUT reports which come over the INTERRUPT 
IN endpoint (usually EP 1 IN). FEATURE reports must come through the 
GET_FEATURE request over the CONTROL endpoint, initiated by the 
HIDIOCGFEATURE ioctl (Note that this ioctl is part of what Jiri has 
staged for the next merge window, and is not part of the current 2.6.34 
Kernel). OUTPUT reports are never sent from the device on the INTERRUPT 
IN endpoint. In short, if it comes from read(), it's always an INPUT report.

Alan.


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-06-30 12:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 11:10 Report ID problem with HID-RAW interface usage Amit Nagal
     [not found] ` <AANLkTinrmRsB39gj7Ie4xCr3fhP3jU1dfYuVrkiKv347-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-29 16:30   ` Alan Ott
2010-06-29 23:32     ` Xiaofan Chen
2010-06-30  7:39       ` Amit Nagal
2010-06-30  7:56         ` Amit Nagal
2010-06-30  7:57           ` Jiri Kosina
     [not found]     ` <4C2A1FA0.6020704-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2010-06-30  9:26       ` Jiri Kosina
2010-06-30 10:30         ` Amit Nagal
     [not found]           ` <AANLkTilf1JU_GPlqE-FeaRon6IMqgA68WZ964PJfLpSP-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-30 10:55             ` Jiri Kosina
2010-06-30 11:14               ` Amit Nagal
2010-06-30 12:54                 ` Alan Ott
2010-06-30 13:04                   ` Xiaofan Chen
2010-06-30 13:06                     ` Jiri Kosina
2010-06-30 14:09                       ` Xiaofan Chen
     [not found]                         ` <AANLkTil0S747k-MomthJW4dv2WwB-abjZmGmxf3fH59y-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-30 14:32                           ` Alan Ott
2010-06-30 23:33                             ` Xiaofan Chen
2010-06-30 13:13                     ` Antonio Ospite
2010-06-30 14:02                       ` Xiaofan Chen
2010-06-30 14:10                         ` Alan Ott
2010-06-30 14:16                         ` Antonio Ospite
2010-06-30 16:40                   ` Amit Nagal
     [not found]                     ` <AANLkTimb_xMYTZYAm51lmHEkYvrvegwbmkUyJldxYA-f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-01  2:40                       ` Xiaofan Chen
2010-07-01 13:16                       ` Alan Ott
2010-07-02  6:46                         ` Amit Nagal
     [not found]                           ` <AANLkTilFyRjuP4VUmJolYhloDol5B7HsYV9d5SD8vZPo-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-02 15:05                             ` Alan Ott
     [not found]                               ` <4C2E0057.30206-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2010-07-02 16:19                                 ` Amit Nagal
     [not found]               ` <alpine.LNX.2.00.1006301252380.13809-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2010-06-30 12:32                 ` Alan Ott [this message]
     [not found]                   ` <4C2B3956.6080107-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2010-06-30 12:38                     ` Jiri Kosina
2010-06-30 13:50         ` [PATCH 0/1] HID: Send Report ID when numbered reports are sent over the control endpoint Alan Ott
2010-06-30 13:50           ` Alan Ott
2010-06-30 13:50         ` [PATCH 1/1] " Alan Ott
2010-06-30 13:50           ` Alan Ott
     [not found]           ` <1277905836-3949-2-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2010-07-11 21:14             ` Jiri Kosina
2010-07-11 21:14               ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2B3956.6080107@signal11.us \
    --to=alan-yzvjwurpmd1zbrfiqnyvsa@public.gmane.org \
    --cc=helloin.amit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.