All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jiri Pirko <jpirko@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, ole@ans.pl
Subject: Re: [PATCH net-next-2.6] netfilter: remove deprecated config option NF_CT_ACCT
Date: Wed, 30 Jun 2010 15:42:17 +0200	[thread overview]
Message-ID: <4C2B49B9.5050302@trash.net> (raw)
In-Reply-To: <20100630131153.GB2582@psychotron.brq.redhat.com>

Jiri Pirko wrote:
> Wed, Jun 30, 2010 at 02:53:17PM CEST, kaber@trash.net wrote:
>   
>> Jiri Pirko wrote:
>>     
>>> Apart your patch doesn't remove option from defconfigs (not sure if that's
>>> necessary or not), your patch also do not print warning in connbytes_mt_init.
>>> That would make connbytes silently non-functional. Therefore I think my patch is
>>> better (more complete).
>>>       
>> The patch I have queued is automatically enabling accounting when
>> the connbytes match is used and is printing a warning.
>>     
>
> ok, that looks fine to me. What about those config options in def_config files?
>   

I usually leave those for the architecture maintainers.


  reply	other threads:[~2010-06-30 13:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 15:45 [PATCH net-next-2.6] netfilter: remove deprecated config option NF_CT_ACCT Jiri Pirko
2010-06-30 12:10 ` Patrick McHardy
2010-06-30 12:49   ` Jiri Pirko
2010-06-30 12:53     ` Patrick McHardy
2010-06-30 13:11       ` Jiri Pirko
2010-06-30 13:42         ` Patrick McHardy [this message]
2010-06-30 14:15           ` Jiri Pirko
2010-06-30 17:48           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2B49B9.5050302@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=jpirko@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=ole@ans.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.