From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Björn Smedman" <bjorn.smedman@venatech.se>,
"Pavel Roskin" <proski@gnu.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] ath9k: fix TSF after reset on AR913x
Date: Thu, 01 Jul 2010 09:51:17 +0200 [thread overview]
Message-ID: <4C2C48F5.70307@openwrt.org> (raw)
In-Reply-To: <1277966396.3788.0.camel@jlt3.sipsolutions.net>
On 2010-07-01 8:39 AM, Johannes Berg wrote:
> On Thu, 2010-07-01 at 02:47 +0200, Felix Fietkau wrote:
>
>> No, the TSF value at this point is not accurate. It differs
>> semi-randomly by a few orders of magnitude from the time measured by the
>> CPU timer. The value I put in above is just an approximation, but since
>> making it completely accurate is impossible, I figured this is good
>> enough, especially since the value will most likely not deviate much
>> from what I've measured here.
>
> Are you sure it doesn't depend on CPU speed as well since the driver is
> involved here? Or DMA speed?
Yes, it depends on CPU speed, but there's not a lot of variation
possible, because this only affects one, maybe two different SoC types
with similar CPU speed, and a large part of the delay is probably
constant because of udelay calls.
As I said, being precise here is impossible anyway, this is only a
workaround for a hw issue, and this simple approximation should not
cause any problems for anything. Even if the AP's TSF jumps by a few
microseconds, the clients will catch on to that pretty quickly.
- Felix
next prev parent reply other threads:[~2010-07-01 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 0:07 [PATCH] ath9k: fix TSF after reset on AR913x Felix Fietkau
2010-06-30 22:02 ` Pavel Roskin
2010-06-30 22:38 ` Björn Smedman
2010-07-01 0:47 ` Felix Fietkau
2010-07-01 6:39 ` Johannes Berg
2010-07-01 7:51 ` Felix Fietkau [this message]
2010-07-01 0:45 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2C48F5.70307@openwrt.org \
--to=nbd@openwrt.org \
--cc=bjorn.smedman@venatech.se \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.