All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Nazar <nazard.lkml@gmail.com>
To: linux-nfs@vger.kernel.org
Subject: Fix memcmp result comparison error for uuid match.
Date: Thu, 01 Jul 2010 05:43:57 -0400	[thread overview]
Message-ID: <4C2C635D.9000906@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

  Small typo in the new fs uuid comparison code.


[-- Attachment #2: nfs-utils-fsuuid-memcmp.diff --]
[-- Type: text/plain, Size: 606 bytes --]

commit 361f6d6c5da3c5c5ba709f8f3704865b0f7267cc
Author: Doug Nazar <nazard.michi@gmail.com>
Date:   Thu Jul 1 05:37:23 2010 -0400

    Fix memcmp result comparison error for uuid match.

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index 9e1b164..bf18a9a 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -513,7 +513,7 @@ void nfsd_fh(FILE *f)
 					for (type = 0;
 					     uuid_by_path(path, type, uuidlen, u);
 					     type++)
-						if (memcmp(u, fhuuid, uuidlen) != 0)
+						if (memcmp(u, fhuuid, uuidlen) == 0)
 							break;
 
 				if (memcmp(u, fhuuid, uuidlen) != 0)

             reply	other threads:[~2010-07-01  9:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01  9:43 Doug Nazar [this message]
2010-07-19 15:00 ` Fix memcmp result comparison error for uuid match Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2C635D.9000906@gmail.com \
    --to=nazard.lkml@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.