From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: Re: [PATCH 2/6] trace: fix T_INFO_FIRST_OFFSET Date: Thu, 01 Jul 2010 10:53:33 +0100 Message-ID: <4C2C659D.9080007@eu.citrix.com> References: <4C2A2E370200007800008A61@vpn.id2.novell.com> <4C2B7BC60200007800008DFF@vpn.id2.novell.com> <4C2B62AB.3020006@eu.citrix.com> <4C2C80E402000078000090AD@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C2C80E402000078000090AD@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 01/07/10 10:49, Jan Beulich wrote: >>>> On 30.06.10 at 18:12, George Dunlap wrote: >> + offset_in_bytes = ((char *)&((struct t_info *)(NULL))->mfn_offset[NR_CPUS]) - (char *)(NULL); > > Why can't this just be offsetof(struct t_info, mfn_offset[NR_CPUS])? Ah... forgot about that one. Thanks, I'll modify that in my patch series. -George