From: Nic Henke <nic@cray.com>
To: lustre-devel@lists.lustre.org
Subject: [Lustre-devel] o2iblnd bug ?
Date: Thu, 1 Jul 2010 11:18:43 -0500 [thread overview]
Message-ID: <4C2CBFE3.4040901@cray.com> (raw)
There looks to be a bug in the o2iblnd (and maybe other LNDs...) in
kiblnd_tx_done.
When tx_lntmsg[1] has a reply allocated (lnet_create_reply_msg) for a
GET_REQ, we are committed to lnet_finalize that no matter the status of
the RDMA. However, kiblnd_tx_done will call lnet_finalize() with the
'error' status on both the request (lntmsg[0]) and the allocated reply.
This could lead to the upper layer receiving a REPLY event for a message
it has already nuked due to the EIO on the originial request.
In the pttlnd and qswlnd, they seem to handle this properly. They will
complete the request with rc=0, then complete the reply with rc=-EIO.
So - is this really a bug or just inconsequential differences ?
This looks to be present in HEAD, as well as b1_8 and friends.
Cheers,
Nic
next reply other threads:[~2010-07-01 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 16:18 Nic Henke [this message]
2010-07-01 21:27 ` [Lustre-devel] o2iblnd bug ? Liang Zhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2CBFE3.4040901@cray.com \
--to=nic@cray.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.