From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OUTRy-0002li-7t for mharc-grub-devel@gnu.org; Thu, 01 Jul 2010 19:45:46 -0400 Received: from [140.186.70.92] (port=52803 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUTRU-0002id-7S for grub-devel@gnu.org; Thu, 01 Jul 2010 19:45:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUTQk-0000Ax-17 for grub-devel@gnu.org; Thu, 01 Jul 2010 19:45:15 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:49182) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUTQj-0000Aj-Qs for grub-devel@gnu.org; Thu, 01 Jul 2010 19:44:30 -0400 Received: by bwz9 with SMTP id 9so1571912bwz.0 for ; Thu, 01 Jul 2010 16:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=PX8+vdvurfZFntSJ2rQWp0+RwQreoqEjYZVz4shdgZ4=; b=CqnjHgdE99FYJ+ppdRnMvyHXpvDc9e4ocB54p6nGTNXvXGqUP0/88ny4nWK94U5mlB hg3d3UnmjoxNtVuPWBC86EiE5UlE586NyqiZh4OBLwgz179y/KESqqGW7n8R3N/1VOYv tb7VCj0SPCXMeoErRMdLuNe9Qd4ZvRPvteulw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=u3XKt4bupOaIVVUEnsUG5RQIoE+T7VBAZV+g/bKU71ImpLJPdWd4x1FdvKBkA5h42W uGNE74B4QYLaocEHXfdS7gF8Zk8c91tSMgcJwUqXR96UphXSRQ1BDg/d1qXYNiFl49x6 YJc2cbosJk9u4LaWHJTgZ9IOiqKtD2vfwHqHU= Received: by 10.204.19.83 with SMTP id z19mr214380bka.43.1278027868906; Thu, 01 Jul 2010 16:44:28 -0700 (PDT) Received: from debian.bg45.phnet ([81.62.28.146]) by mx.google.com with ESMTPS id y27sm151640bkw.2.2010.07.01.16.44.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 01 Jul 2010 16:44:28 -0700 (PDT) Message-ID: <4C2D2855.2020707@gmail.com> Date: Fri, 02 Jul 2010 01:44:21 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 MIME-Version: 1.0 To: grub-devel@gnu.org References: <20100602190744.GA4058@rangda.stickybit.se> <4C2D07AC.6020006@gmail.com> <20100701233226.GU21862@riva.ucam.org> In-Reply-To: <20100701233226.GU21862@riva.ucam.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig6F70ED7BBAA52D083627AC0E" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix root device detection for lvm2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2010 23:45:45 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6F70ED7BBAA52D083627AC0E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/02/2010 01:32 AM, Colin Watson wrote: > On Thu, Jul 01, 2010 at 11:25:00PM +0200, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: > =20 >> On 06/02/2010 09:07 PM, sean finney wrote: >> =20 >>> Index: b/util/grub.d/10_linux.in >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- a/util/grub.d/10_linux.in >>> +++ b/util/grub.d/10_linux.in >>> @@ -43,7 +43,8 @@ >>> esac >>> =20 >>> if [ "x${GRUB_DEVICE_UUID}" =3D "x" ] || [ "x${GRUB_DISABLE_LINUX_UU= ID}" =3D "xtrue" ] \ >>> - || ! test -e "/dev/disk/by-uuid/${GRUB_DEVICE_UUID}" ; then >>> + || ! test -e "/dev/disk/by-uuid/${GRUB_DEVICE_UUID}" \ >>> + || [ "`grub-probe -t abstraction --device ${GRUB_DEVICE} | sed -= e 's,.*\(lvm\).*,\1,'`" =3D "lvm" ] ; then >>> LINUX_ROOT_DEVICE=3D${GRUB_DEVICE} >>> else >>> LINUX_ROOT_DEVICE=3DUUID=3D${GRUB_DEVICE_UUID} >>> =20 >> Applied with some chages. Thanks >> =20 > The changes seem to have been to simplify the test to: > > [ "x`grub-probe -t abstraction --device ${GRUB_DEVICE}`" =3D "xlvm" = ] > > Unfortunately this is an incorrect simplification. grub-probe can prin= t > multiple abstractions, and does in the case of e.g. LVM on RAID. If it= > is correct to avoid UUIDs for plain LVM, it is also correct to avoid > them for LVM on RAID. > > =20 Ok I agree. The problem with original patch was that it would accept ttttlvmuuu too. Feel free to fix. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig6F70ED7BBAA52D083627AC0E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkwtKFUACgkQNak7dOguQgmwPQD/WfA89KgngTDOVNaIf7uilHAk Cfr8LEYMsapQYl9LG18A/il8anqUAj2UZ6EuQYk6nqTQiRDatenbe2cvyhCFZQaD =MfaV -----END PGP SIGNATURE----- --------------enig6F70ED7BBAA52D083627AC0E--