All of lore.kernel.org
 help / color / mirror / Atom feed
From: ben@simtec.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] DMAENGINE: correct PL080 register header file
Date: Fri, 02 Jul 2010 10:50:05 +0100	[thread overview]
Message-ID: <4C2DB64D.8010000@simtec.co.uk> (raw)
In-Reply-To: <1277811367-17694-1-git-send-email-linus.walleij@stericsson.com>

On 29/06/10 12:36, Linus Walleij wrote:
> This PL008 among all other variables named PL080 doesn't seem
> right. Fix it. Also add some missing defined that I use in the
> new PL08x driver.
> 
> Cc: Ben Dooks <ben-linux@fluff.org>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> ---
> Ben can you ACK this? Shouldn't be any big deal.
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
>  arch/arm/include/asm/hardware/pl080.h |    4 +++-
>  arch/arm/mach-s3c64xx/dma.c           |    2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/include/asm/hardware/pl080.h b/arch/arm/include/asm/hardware/pl080.h
> index 6a6c66b..f35b86e 100644
> --- a/arch/arm/include/asm/hardware/pl080.h
> +++ b/arch/arm/include/asm/hardware/pl080.h
> @@ -43,7 +43,7 @@
>  
>  /* Per channel configuration registers */
>  
> -#define PL008_Cx_STRIDE				(0x20)
> +#define PL080_Cx_STRIDE				(0x20)
>  #define PL080_Cx_BASE(x)			((0x100 + (x * 0x20)))
>  #define PL080_Cx_SRC_ADDR(x)			((0x100 + (x * 0x20)))
>  #define PL080_Cx_DST_ADDR(x)			((0x104 + (x * 0x20)))
> @@ -68,6 +68,8 @@
>  #define PL080_CONTROL_TC_IRQ_EN			(1 << 31)
>  #define PL080_CONTROL_PROT_MASK			(0x7 << 28)
>  #define PL080_CONTROL_PROT_SHIFT		(28)
> +#define PL080_CONTROL_PROT_CACHE		(1 << 30)
> +#define PL080_CONTROL_PROT_BUFF			(1 << 29)
>  #define PL080_CONTROL_PROT_SYS			(1 << 28)
>  #define PL080_CONTROL_DST_INCR			(1 << 27)
>  #define PL080_CONTROL_SRC_INCR			(1 << 26)
> diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
> index 5567e03..e7d03ab 100644
> --- a/arch/arm/mach-s3c64xx/dma.c
> +++ b/arch/arm/mach-s3c64xx/dma.c
> @@ -697,7 +697,7 @@ static int s3c64xx_dma_init1(int chno, enum dma_ch chbase,
>  		chptr->number = chno;
>  		chptr->dmac = dmac;
>  		chptr->regs = regptr;
> -		regptr += PL008_Cx_STRIDE;
> +		regptr += PL080_Cx_STRIDE;
>  	}
>  
>  	/* for the moment, permanently enable the controller */

  reply	other threads:[~2010-07-02  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 11:36 [PATCH 1/2] DMAENGINE: correct PL080 register header file Linus Walleij
2010-06-29 11:36 ` Linus Walleij
2010-07-02  9:50 ` Ben Dooks [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-07-21 22:06 Linus Walleij
2010-07-21 22:06 ` Linus Walleij
2010-08-09 10:47 Linus Walleij
2010-08-09 10:47 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2DB64D.8010000@simtec.co.uk \
    --to=ben@simtec.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.