Re: [PATCH] support for Hauppauge WinTV MiniStic IR remote

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 15-06-2010 13:23, Richard Zidlicky escreveu:
> Hi,
> 
> I have guessed which gpio line to use and activated the ir-remote receiver.
> The keymap seems to work fairly well with the supplied DSR-0112 remote, mostly
> tested it with xev as I do not have a working lircd on this computer.
> 
> The patch is against 2.6.34.

There are a few CodingStyle issues. Also, please send your Signed-off-by:

Cheers,
Mauro

patching file drivers/media/dvb/siano/smsir.h
patching file drivers/media/dvb/siano/smsir.c
patching file drivers/media/dvb/siano/sms-cards.c
Patch applies OK
WARNING: please, no space before tabs
#77: FILE: drivers/media/dvb/siano/smsir.c:73:
+^I^I^I^I^IKEY_CHANNELUP, ^IKEY_CHANNELDOWN,$

WARNING: line over 80 characters
#115: FILE: drivers/media/dvb/siano/smsir.c:313:
+	key_map = keyboard_layout_maps[coredev->ir.ir_kb_type].keyboard_layout_map;

ERROR: trailing whitespace
#116: FILE: drivers/media/dvb/siano/smsir.c:314:
+^I^I$

WARNING: space prohibited between function name and open parenthesis '('
#117: FILE: drivers/media/dvb/siano/smsir.c:315:
+	memset (input_dev->keybit, 0, sizeof(input_dev->keybit));

ERROR: spaces required around that '=' (ctx:VxV)
#118: FILE: drivers/media/dvb/siano/smsir.c:316:
+	for (i=0; i<IR_KEYBOARD_LAYOUT_SIZE; i++) {
 	      ^

ERROR: spaces required around that '<' (ctx:VxV)
#118: FILE: drivers/media/dvb/siano/smsir.c:316:
+	for (i=0; i<IR_KEYBOARD_LAYOUT_SIZE; i++) {
 	           ^

WARNING: space prohibited between function name and open parenthesis '('
#120: FILE: drivers/media/dvb/siano/smsir.c:318:
+			set_bit (key_map[i], input_dev->keybit);

ERROR: Missing Signed-off-by: line(s)

total: 4 errors, 4 warnings, 79 lines checked

patches/lmml_106247_support_for_hauppauge_wintv_ministic_ir_remote.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.